-
-
Notifications
You must be signed in to change notification settings - Fork 720
Dolt Stash CLI Migration #9369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Dolt Stash CLI Migration #9369
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
94730ad
Rough draft for stash migration
3258d0f
[ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/upda…
NathanGabrielson 50a3be6
Query system table, code is now less headache inducing
0df5282
Couple things I forgot to change back
531b7c6
Moving stuff around, small fixes
aefb178
No more dEnv, get rid of bad sql interpolation
4cd3a04
Small fixes
63a2451
[ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/upda…
NathanGabrielson 6b9a55c
Fixing tests & code cleanup
1f08c69
stop skipping tests
18dc62e
Fix engine test, stash.go cleanup
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,319 @@ | ||
| // Copyright 2023 Dolthub, Inc. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package commands | ||
|
|
||
| import ( | ||
| "bytes" | ||
| "context" | ||
| "fmt" | ||
| "strconv" | ||
| "strings" | ||
|
|
||
| "github.com/dolthub/go-mysql-server/sql" | ||
| "github.com/gocraft/dbr/v2" | ||
| "github.com/gocraft/dbr/v2/dialect" | ||
|
|
||
| "github.com/dolthub/dolt/go/cmd/dolt/cli" | ||
| "github.com/dolthub/dolt/go/cmd/dolt/errhand" | ||
| eventsapi "github.com/dolthub/dolt/go/gen/proto/dolt/services/eventsapi/v1alpha1" | ||
| "github.com/dolthub/dolt/go/libraries/doltcore/doltdb" | ||
| "github.com/dolthub/dolt/go/libraries/doltcore/env" | ||
| "github.com/dolthub/dolt/go/libraries/doltcore/ref" | ||
| "github.com/dolthub/dolt/go/libraries/utils/argparser" | ||
| ) | ||
|
|
||
| const ( | ||
| PushCmdRef = "push" | ||
| PopCmdRef = "pop" | ||
| DropCmdRef = "drop" | ||
| ClearCmdRef = "clear" | ||
| ListCmdRef = "list" | ||
| ) | ||
|
|
||
| var stashDocs = cli.CommandDocumentationContent{ | ||
| ShortDesc: "Stash the changes in a dirty workspace away.", | ||
| LongDesc: `Use dolt stash when you want to record the current state of the workspace and the index, but want to go back to a clean workspace. | ||
|
|
||
| The command saves your local modifications away and reverts the workspace to match the HEAD commit. The stash entries that are saved away can be listed with 'dolt stash list'. | ||
| `, | ||
| Synopsis: []string{ | ||
| "", // this is for `dolt stash` itself. | ||
| "list", | ||
| "pop {{.LessThan}}stash{{.GreaterThan}}", | ||
| "clear", | ||
| "drop {{.LessThan}}stash{{.GreaterThan}}", | ||
| }, | ||
| } | ||
|
|
||
| type StashCmd struct{} | ||
|
|
||
| // Name returns the name of the Dolt cli command. This is what is used on the command line to invoke the command | ||
| func (cmd StashCmd) Name() string { | ||
| return "stash" | ||
| } | ||
|
|
||
| // Description returns a description of the command | ||
| func (cmd StashCmd) Description() string { | ||
| return "Stash the changes in a dirty workspace away." | ||
| } | ||
|
|
||
| func (cmd StashCmd) Docs() *cli.CommandDocumentation { | ||
| ap := cmd.ArgParser() | ||
| return cli.NewCommandDocumentation(stashDocs, ap) | ||
| } | ||
|
|
||
| func (cmd StashCmd) ArgParser() *argparser.ArgParser { | ||
| return cli.CreateStashArgParser() | ||
| } | ||
|
|
||
| // EventType returns the type of the event to log | ||
| func (cmd StashCmd) EventType() eventsapi.ClientEventType { | ||
| return eventsapi.ClientEventType_STASH | ||
| } | ||
|
|
||
| // Exec executes the command | ||
| func (cmd StashCmd) Exec(ctx context.Context, commandStr string, args []string, _ *env.DoltEnv, cliCtx cli.CliContext) int { | ||
| ap := cli.CreateStashArgParser() | ||
|
|
||
| apr, _, terminate, status := ParseArgsOrPrintHelp(ap, commandStr, args, stashDocs) | ||
| if terminate { | ||
| return status | ||
| } | ||
| if len(apr.Args) > 2 { | ||
| cli.PrintErrln(fmt.Errorf("dolt stash takes 2 arguments, received %d", len(apr.Args))) | ||
| return 1 | ||
| } | ||
|
|
||
| subcommand := "push" | ||
| if len(apr.Args) > 0 { | ||
| subcommand = strings.ToLower(apr.Arg(0)) | ||
| } | ||
|
|
||
| queryist, sqlCtx, closeFunc, err := cliCtx.QueryEngine(ctx) | ||
| if err != nil { | ||
| cli.PrintErrln(errhand.VerboseErrorFromError(err)) | ||
| return 1 | ||
| } | ||
| if closeFunc != nil { | ||
| defer closeFunc() | ||
| } | ||
|
|
||
| idx := 0 | ||
| if apr.NArg() > 1 { | ||
| idx, err = parseStashIndex(apr.Arg(1)) | ||
| if err != nil { | ||
| cli.PrintErrln(errhand.VerboseErrorFromError(err)) | ||
| return 1 | ||
| } | ||
| } | ||
|
|
||
| switch subcommand { | ||
| case PushCmdRef: | ||
| err = stashPush(queryist, sqlCtx, apr, subcommand) | ||
| case PopCmdRef, DropCmdRef: | ||
| err = stashRemove(queryist, sqlCtx, cliCtx, apr, subcommand, idx) | ||
| case ListCmdRef: | ||
| err = stashList(ctx, cliCtx) | ||
| case ClearCmdRef: | ||
| err = stashClear(queryist, sqlCtx, apr, subcommand) | ||
| default: | ||
| err = fmt.Errorf("unknown stash subcommand %s", subcommand) | ||
| } | ||
|
|
||
| if err != nil { | ||
| cli.PrintErrln(errhand.VerboseErrorFromError(err)) | ||
| if strings.Contains(err.Error(), "No local changes to save") { | ||
| return 0 | ||
| } | ||
| return 1 | ||
| } | ||
| return 0 | ||
| } | ||
|
|
||
| func stashPush(queryist cli.Queryist, sqlCtx *sql.Context, apr *argparser.ArgParseResults, subcommand string) error { | ||
| rowIter, err := stashQuery(queryist, sqlCtx, apr, subcommand) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| stashes, err := getStashesSQL(sqlCtx, queryist, 1) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| stash := stashes[0] | ||
| cli.Println(fmt.Sprintf("Saved working directory and index state WIP on %s: %s %s", stash.BranchReference, stash.CommitHash, stash.Description)) | ||
| _, err = sql.RowIterToRows(sqlCtx, rowIter) | ||
| return err | ||
| } | ||
|
|
||
| func stashRemove(queryist cli.Queryist, sqlCtx *sql.Context, cliCtx cli.CliContext, apr *argparser.ArgParseResults, subcommand string, idx int) error { | ||
| stashes, err := getStashesSQL(sqlCtx, queryist, 0) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| if len(stashes) == 0 { | ||
| return fmt.Errorf("No stash entries found.") | ||
| } | ||
| if len(stashes)-1 < idx { | ||
| return fmt.Errorf("stash index stash@{%d} does not exist", idx) | ||
| } | ||
|
|
||
| interpolatedQuery, err := generateStashSql(apr, subcommand) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| _, rowIter, _, err := queryist.Query(sqlCtx, interpolatedQuery) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| if subcommand == PopCmdRef { | ||
| ret := StatusCmd{}.Exec(sqlCtx, StatusCmd{}.Name(), []string{}, nil, cliCtx) | ||
| if ret != 0 { | ||
| cli.Println("The stash entry is kept in case you need it again.") | ||
| return err | ||
| } | ||
| } | ||
|
|
||
| cli.Println(fmt.Sprintf("Dropped refs/stash@{%v} (%s)", idx, stashes[idx].CommitHash)) | ||
| _, err = sql.RowIterToRows(sqlCtx, rowIter) | ||
| return err | ||
| } | ||
|
|
||
| func stashList(ctx context.Context, cliCtx cli.CliContext) error { | ||
| queryist, sqlCtx, closeFunc, err := cliCtx.QueryEngine(ctx) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| if closeFunc != nil { | ||
| defer closeFunc() | ||
| } | ||
|
|
||
| stashes, err := getStashesSQL(sqlCtx, queryist, 0) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| for _, stash := range stashes { | ||
| cli.Println(fmt.Sprintf("%s: WIP on %s: %s %s", stash.Name, stash.BranchReference, stash.CommitHash, stash.Description)) | ||
| } | ||
|
|
||
| return nil | ||
| } | ||
|
|
||
| func stashClear(queryist cli.Queryist, sqlCtx *sql.Context, apr *argparser.ArgParseResults, subcommand string) error { | ||
| rowIter, err := stashQuery(queryist, sqlCtx, apr, subcommand) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| _, err = sql.RowIterToRows(sqlCtx, rowIter) | ||
| return err | ||
| } | ||
|
|
||
| // getStashesSQL queries the dolt_stashes system table to return the requested number of stashes. A limit of 0 will get all stashes | ||
| func getStashesSQL(sqlCtx *sql.Context, queryist cli.Queryist, limit int) ([]*doltdb.Stash, error) { | ||
| limitStr := fmt.Sprintf("limit %d", limit) | ||
| if limit == 0 { | ||
| limitStr = "" | ||
| } | ||
|
|
||
| qry := fmt.Sprintf("select stash_id, branch, hash, commit_message from dolt_stashes where name = '%s' order by stash_id ASC %s;", doltdb.DoltCliRef, limitStr) | ||
| rows, err := GetRowsForSql(queryist, sqlCtx, qry) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| var stashes []*doltdb.Stash | ||
| for _, s := range rows { | ||
| id, ok := s[0].(string) | ||
| if !ok { | ||
| return nil, fmt.Errorf("Invalid stash id") | ||
| } | ||
|
|
||
| branch, ok := s[1].(string) | ||
| if !ok { | ||
| return nil, fmt.Errorf("invalid stash branch") | ||
| } | ||
| fullBranch := ref.NewBranchRef(branch).String() | ||
|
|
||
| stashHash, ok := s[2].(string) | ||
| if !ok { | ||
| return nil, fmt.Errorf("invalid stash hash") | ||
| } | ||
|
|
||
| msg, ok := s[3].(string) | ||
| if !ok { | ||
| return nil, fmt.Errorf("invalid stash message") | ||
| } | ||
|
|
||
| stashes = append(stashes, &doltdb.Stash{ | ||
| Name: id, | ||
| BranchReference: fullBranch, | ||
| Description: msg, | ||
| CommitHash: stashHash, | ||
| }) | ||
| } | ||
|
|
||
| return stashes, nil | ||
| } | ||
|
|
||
| // generateStashSql returns the query that will call the `DOLT_STASH` stored procedure. | ||
| func generateStashSql(apr *argparser.ArgParseResults, subcommand string) (string, error) { | ||
| var buffer bytes.Buffer | ||
| var params []interface{} | ||
| buffer.WriteString("CALL DOLT_STASH(?, ?") | ||
| params = append(params, subcommand) | ||
| params = append(params, doltdb.DoltCliRef) | ||
|
|
||
| if len(apr.Args) == 2 { | ||
| params = append(params, apr.Arg(1)) | ||
| buffer.WriteString(", ?") | ||
| } | ||
|
|
||
| if apr.Contains(cli.AllFlag) { | ||
| buffer.WriteString(", '--all'") | ||
| } | ||
| if apr.Contains(cli.IncludeUntrackedFlag) { | ||
| buffer.WriteString(", '--include-untracked'") | ||
| } | ||
|
|
||
| buffer.WriteString(")") | ||
| interpolatedQuery, err := dbr.InterpolateForDialect(buffer.String(), params, dialect.MySQL) | ||
| return interpolatedQuery, err | ||
| } | ||
|
|
||
| func stashQuery(queryist cli.Queryist, sqlCtx *sql.Context, apr *argparser.ArgParseResults, subcommand string) (sql.RowIter, error) { | ||
| interpolatedQuery, err := generateStashSql(apr, subcommand) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| _, rowIter, _, err := queryist.Query(sqlCtx, interpolatedQuery) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| return rowIter, nil | ||
| } | ||
|
|
||
| func parseStashIndex(stashID string) (int, error) { | ||
| var err error | ||
| stashID = strings.TrimSuffix(strings.TrimPrefix(stashID, "stash@{"), "}") | ||
| idx, err := strconv.Atoi(stashID) | ||
| if err != nil { | ||
| return 0, fmt.Errorf("error: %s is not a valid reference", stashID) | ||
| } | ||
|
|
||
| return idx, nil | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.