Skip to content

Implemented dolt_history_dolt_schemas and dolt_diff_dolt_schemas#9361

Merged
timsehn merged 30 commits intomainfrom
tim/history-tables-dolt-schemas
Jun 25, 2025
Merged

Implemented dolt_history_dolt_schemas and dolt_diff_dolt_schemas#9361
timsehn merged 30 commits intomainfrom
tim/history-tables-dolt-schemas

Conversation

@timsehn
Copy link
Copy Markdown
Contributor

@timsehn timsehn commented Jun 16, 2025

Fixes: #9360

@coffeegoddd
Copy link
Copy Markdown
Contributor

@timsehn DOLT

comparing_percentages
100.000000 to 100.000000
version result total
c0d1de8 ok 5937457
version total_tests
c0d1de8 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Copy Markdown
Contributor

@timsehn DOLT

comparing_percentages
100.000000 to 100.000000
version result total
0775c17 ok 5937457
version total_tests
0775c17 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Copy Markdown
Contributor

@timsehn DOLT

comparing_percentages
100.000000 to 100.000000
version result total
a717f4b ok 5937457
version total_tests
a717f4b 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Copy Markdown
Contributor

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
053ada5 ok 5937457
version total_tests
053ada5 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Copy Markdown
Contributor

@timsehn DOLT

comparing_percentages
100.000000 to 100.000000
version result total
40d488b ok 5937457
version total_tests
40d488b 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Copy Markdown
Contributor

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
255c488 ok 5937457
version total_tests
255c488 5937457
correctness_percentage
100.0

@timsehn timsehn requested a review from bheni June 23, 2025 18:11
@timsehn timsehn linked an issue Jun 23, 2025 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

@bheni bheni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got part way through it before you said you were going to have claude delete dead code. I'll review that.

@coffeegoddd
Copy link
Copy Markdown
Contributor

@timsehn DOLT

comparing_percentages
100.000000 to 100.000000
version result total
190a5f4 ok 5937457
version total_tests
190a5f4 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Copy Markdown
Contributor

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
c73d6ad ok 5937457
version total_tests
c73d6ad 5937457
correctness_percentage
100.0

Copy link
Copy Markdown
Contributor

@bheni bheni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks a lot better. If the tests pass I think you're good.

@coffeegoddd
Copy link
Copy Markdown
Contributor

@timsehn DOLT

comparing_percentages
100.000000 to 100.000000
version result total
6cae5ef ok 5937457
version total_tests
6cae5ef 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Copy Markdown
Contributor

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
2510316 ok 5937457
version total_tests
2510316 5937457
correctness_percentage
100.0

@timsehn timsehn merged commit 7c3542a into main Jun 25, 2025
21 of 22 checks passed
@Hydrocharged Hydrocharged deleted the tim/history-tables-dolt-schemas branch December 15, 2025 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement dolt_history_dolt_procedures and dolt_diff_dolt_procedures add dolt_history_dolt_schemas and dolt_diff_dolt_schemas

3 participants