Conversation
…when pushing to a dolt sql-server that is itself running GC. A push to a remote works by uploading the missing content and then adding references to it in the remote datastore. If the remote is running a GC during the push, it is possible for the newly added data to be collected and no longer be available when the references are added. This should cause a transient failure which is safe is retry. There were a couple bugs which could instead cause a panic. This makes some changes to safeguard against those case.
Contributor
Contributor
Contributor
|
@coffeegoddd DOLT
|
macneale4
reviewed
Jun 10, 2025
Contributor
macneale4
left a comment
macneale4
left a comment
There was a problem hiding this comment.
The panics make me a little nervous. Seems a little over the top. Is the ref counting critical enough that you want to hear from a user when this happens?
go/store/nbs/file_table_reader.go
Outdated
| if cnt == 0 { | ||
| return fra.f.Close() | ||
| } else if cnt < 0 { | ||
| panic("invalid cnt on fileReaderAt") |
Contributor
There was a problem hiding this comment.
Also, why panic? Yeah, it's a bug, but is it worth bringing down the server? Could we just put an error in the logs and move on?
…ynamic enabled asserts.
…lakey asserts for now.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A push to a remote works by uploading the missing content and then adding references to it in the remote datastore. If the remote is running a GC during the push, it is possible for the newly added data to be collected and no longer be available when the references are added.
This should cause a transient failure which is safe is retry. There were a couple bugs which could instead cause a panic. This makes some changes to safeguard against those case.