Skip to content

Added a new constant for string columns created during schema import.#9272

Merged
timsehn merged 1 commit intomainfrom
tim/smaller-inferred-varchar-cols
May 29, 2025
Merged

Added a new constant for string columns created during schema import.#9272
timsehn merged 1 commit intomainfrom
tim/smaller-inferred-varchar-cols

Conversation

@timsehn
Copy link
Copy Markdown
Contributor

@timsehn timsehn commented May 29, 2025

Length is 200 instead of 1023.

Fixes: #8972

Copy link
Copy Markdown
Contributor

@macneale4 macneale4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@coffeegoddd
Copy link
Copy Markdown
Contributor

@timsehn DOLT

comparing_percentages
100.000000 to 100.000000
version result total
5548e0f ok 5937457
version total_tests
5548e0f 5937457
correctness_percentage
100.0

@timsehn timsehn merged commit 5b15cff into main May 29, 2025
34 of 37 checks passed
@Hydrocharged Hydrocharged deleted the tim/smaller-inferred-varchar-cols branch December 15, 2025 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

varchar types inferred on schema import are set to size 1023. 18 occurrences overflow row size limit

3 participants