Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go/libraries/doltcore/merge/merge_prolly_rows.go
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ func mergeProllyTable(
if err != nil {
return nil, nil, err
}
valueMerger := NewValueMerger(mergedSch, tm.leftSch, tm.rightSch, tm.ancSch, leftRows.Pool(), tm.ns)
valueMerger := tm.GetNewValueMerger(mergedSch, leftRows)

if !valueMerger.leftMapping.IsIdentityMapping() {
mergeInfo.LeftNeedsRewrite = true
Expand Down
7 changes: 5 additions & 2 deletions go/libraries/doltcore/merge/merge_rows.go
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,10 @@ func (tm TableMerger) AncRows(ctx context.Context) (prolly.Map, error) {
return rowsFromTable(ctx, tm.ancTbl)
}

func (tm TableMerger) InvolvesRootObjects() bool {
return tm.leftRootObj != nil || tm.rightRootObj != nil || tm.ancRootObj != nil
}

func (tm TableMerger) tableHashes(ctx context.Context) (left, right, anc hash.Hash, err error) {
if tm.leftTbl != nil {
if left, err = tm.leftTbl.HashOf(); err != nil {
Expand Down Expand Up @@ -238,8 +242,7 @@ func (rm *RootMerger) MergeTable(

var tbl *doltdb.Table
var rootObj doltdb.RootObject
involvesRootObjects := tm.leftRootObj != nil || tm.rightRootObj != nil || tm.ancRootObj != nil
if !involvesRootObjects {
if !tm.InvolvesRootObjects() {
if types.IsFormat_DOLT(tm.vrw.Format()) {
tbl, stats, err = mergeProllyTable(ctx, tm, mergeSch, mergeInfo, diffInfo)
} else {
Expand Down
2 changes: 1 addition & 1 deletion go/libraries/doltcore/sqle/dtablefunctions/dolt_diff.go
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,7 @@ func loadCommitStrings(ctx *sql.Context, fromRef, toRef, dotRef interface{}, db
func interfaceToString(r interface{}) (string, error) {
str, ok := r.(string)
if !ok {
return "", fmt.Errorf("received '%v' when expecting commit hash string", str)
return "", fmt.Errorf("received '%v' when expecting commit hash string", r)
}
return str, nil
}
Expand Down
Loading
Loading