Skip to content

manifest safety checks#9269

Merged
macneale4 merged 4 commits intomainfrom
macneale4/manifest-safety
May 29, 2025
Merged

manifest safety checks#9269
macneale4 merged 4 commits intomainfrom
macneale4/manifest-safety

Conversation

@macneale4
Copy link
Copy Markdown
Contributor

@macneale4 macneale4 commented May 29, 2025 •
edited
Loading

Recent user report of a manifest landing that was missing it's format. This will at least prevent the generation of such a file in the future.

@coffeegoddd
Copy link
Copy Markdown
Contributor

coffeegoddd commented May 29, 2025

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
ddc0380 ok 5937457
version total_tests
ddc0380 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Copy Markdown
Contributor

coffeegoddd commented May 29, 2025

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
37d0195 ok 5937457
version total_tests
37d0195 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Copy Markdown
Contributor

coffeegoddd commented May 29, 2025

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
780975b ok 5937457
version total_tests
780975b 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Copy Markdown
Contributor

coffeegoddd commented May 29, 2025

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
862f22b ok 5937457
version total_tests
862f22b 5937457
correctness_percentage
100.0

@macneale4 macneale4 requested a review from reltuk May 29, 2025 23:17
reltuk
reltuk approved these changes May 29, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@reltuk reltuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macneale4 macneale4 merged commit 71e7b33 into main May 29, 2025
21 checks passed
@macneale4 macneale4 deleted the macneale4/manifest-safety branch May 29, 2025 23:57
@BrewTestBot BrewTestBot mentioned this pull request May 31, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reltuk reltuk reltuk approved these changes

Assignees

No one assigned

Labels

correctness_approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@macneale4 @coffeegoddd @reltuk