Skip to content

Allow dumping wrapper values to SQL#9251

Merged
nicktobey merged 1 commit intomainfrom
nicktobey/fmt
May 27, 2025
Merged

Allow dumping wrapper values to SQL#9251
nicktobey merged 1 commit intomainfrom
nicktobey/fmt

Conversation

@nicktobey
Copy link
Contributor

@nicktobey nicktobey commented May 27, 2025

This prevents an issue where commands like dolt dump would fail when trying to export a table as SQL statements if the table has a BLOB column, since it would fail to unwrap the text wrapper value to access the underlying bytes.

Copy link
Contributor

@jycor jycor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coffeegoddd
Copy link
Contributor

@nicktobey DOLT

comparing_percentages
100.000000 to 100.000000
version result total
9d03a4a ok 5937457
version total_tests
9d03a4a 5937457
correctness_percentage
100.0

@nicktobey nicktobey merged commit c5be7d3 into main May 27, 2025
34 of 35 checks passed
@tbantle22 tbantle22 deleted the nicktobey/fmt branch May 28, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants