Skip to content

Made dolt diff --stat -r sql an error #9247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timsehn merged 2 commits into from
May 27, 2025
Merged

Made dolt diff --stat -r sql an error #9247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d2a40e
Made dolt diff --stat -r sql an error
timsehn May 23, 2025
d37b21b
James feedback
timsehn May 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions go/cmd/dolt/commands/diff_output.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,8 +297,7 @@ func (s sqlDiffWriter) WriteViewDiff(ctx context.Context, viewName, oldDefn, new
}

func (s sqlDiffWriter) WriteTableDiffStats(diffStats []diffStatistics, oldColLen, newColLen int, areTablesKeyless bool) error {
// TODO: implement this
return errors.New("diff stats are not supported for sql output")
return errors.New("invalid output format: sql. SQL format diffs only rendered for schema or data changes")
}

func (s sqlDiffWriter) RowWriter(fromTableInfo, toTableInfo *diff.TableInfo, tds diff.TableDeltaSummary, unionSch sql.Schema) (diff.SqlRowDiffWriter, error) {
Expand Down
4 changes: 2 additions & 2 deletions integration-tests/bats/sql-diff.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -888,5 +888,5 @@ EOF
dolt sql -q "create table t (i int primary key);"
run dolt diff --stat -r sql
[ "$status" -eq 1 ]
[[ "$output" =~ "diff stats are not supported for sql output" ]] || false
}
[[ "$output" =~ "invalid output format: sql. SQL format diffs only rendered for schema or data changes" ]] || false
}
Loading