Conversation
|
The only thing I'm a little unsure about is that the new code blows up the log file --> you basically run 7 extra prompts every command, which all throw 3-4 lines in the log so it's really hard to tell what's going on. I think it would be possible, but really tedious to debug what's actually going on with the Some notes for tmrw for myself:
|
|
@NathanGabrielson DOLT
|
|
@NathanGabrielson DOLT
|
macneale4
left a comment
There was a problem hiding this comment.
There were enough requests for changes that I'd like to take another look before you ship it. All simple stuff - the flimsy show warnings equality check needs a fix and testing.
|
The only thing I'm a little unsure about is the show warnings check string manipulation? I had to do a bunch of stuff and was wondering if you think a helper function would be better? Is there a nicer/more conventional way to remove the whitespace? |
|
@NathanGabrielson DOLT
|
macneale4
left a comment
There was a problem hiding this comment.
Just add a test to verify that SHoW WarnINGS behaves.
|
@NathanGabrielson DOLT
|
|
@coffeegoddd DOLT
|
|
@coffeegoddd DOLT
|
|
@coffeegoddd DOLT
|
Fix issue #8875
This pr adds support for warnings in the sql shell. There is now both a summary and detailed list of warnings.
Running
select 1/0;will produce, after the table: