Add a dolt_preview_merge_conflicts_summary table function#9233
Merged
Add a dolt_preview_merge_conflicts_summary table function#9233
dolt_preview_merge_conflicts_summary table function#9233Conversation
b75b15d to
90b0ad8
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new dolt_preview_merge_conflicts_summary table function to report data and schema conflicts between branches, wires it into the engine and test harness, and updates merge logic to support the new functionality.
- Register
PreviewMergeConflictsSummaryTableFunctionand integrate it into SQL engine and tests - Introduce
GetNewValueMerger, Prolly‐backed row accessors, and exposeSchemaMergeonTableMerger - Rename internal
newValueMerger/tryMergeto publicNewValueMerger/TryMergeand update call sites
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| merge/merge_rows.go | Added Prolly map helpers and GetNewValueMerger / SchemaMerge |
| merge/merge_rows.go (imports) | Missing import for durable in rowsFromTable |
| merge/merge_prolly_rows.go | Updated calls to NewValueMerger and TryMerge |
| merge/row_merge_test.go | Updated tests to use NewValueMerger / TryMerge |
| sqle/dtablefunctions/init.go | Registered new table function |
| sqle/enginetest/* | Bulk additions of select * from dolt_preview_merge_conflicts_summary assertions |
| sqle/enginetest/dolt_engine_tests.go and .go | Added harness runners and tests for preview conflict function |
| .github/workflows/merge-perf.yaml | Fixed typo in comment |
Comments suppressed due to low confidence (2)
go/libraries/doltcore/sqle/enginetest/dolt_queries_schema_merge.go:46
- The table function returns
uint64counters, so usinguinthere may cause a type mismatch in the test. Change these literals touint64(1)anduint64(0)to match the function's return types.
Expected: []sql.Row{{"t", uint(1), uint(0)}}
go/libraries/doltcore/merge/merge_rows.go:96
- The code references
durable.ProllyMapFromIndexbut there is no import for thedurablepackage. Add the appropriate import to resolve this symbol and ensure compilation succeeds.
rows, err := durable.ProllyMapFromIndex(rd)
90b0ad8 to
2900f6c
Compare
Contributor
|
@tbantle22 DOLT
|
Contributor
|
@coffeegoddd DOLT
|
cdc4b9e to
95ac4e2
Compare
Contributor
|
@tbantle22 DOLT
|
0fee7cc to
2372540
Compare
Contributor
|
@tbantle22 DOLT
|
nicktobey
reviewed
Jun 4, 2025
go/libraries/doltcore/sqle/dtablefunctions/dolt_preview_merge_conflicts_summary.go
Show resolved
Hide resolved
go/libraries/doltcore/sqle/dtablefunctions/dolt_preview_merge_conflicts_summary.go
Show resolved
Hide resolved
go/libraries/doltcore/sqle/dtablefunctions/dolt_preview_merge_conflicts_summary.go
Outdated
Show resolved
Hide resolved
Contributor
|
@tbantle22 DOLT
|
nicktobey
approved these changes
Jun 7, 2025
go/libraries/doltcore/sqle/dtablefunctions/dolt_preview_merge_conflicts_summary.go
Outdated
Show resolved
Hide resolved
go/libraries/doltcore/sqle/dtablefunctions/dolt_preview_merge_conflicts_summary.go
Show resolved
Hide resolved
go/libraries/doltcore/sqle/dtablefunctions/dolt_preview_merge_conflicts_summary.go
Outdated
Show resolved
Hide resolved
go/libraries/doltcore/sqle/dtablefunctions/dolt_preview_merge_conflicts_summary.go
Outdated
Show resolved
Hide resolved
go/libraries/doltcore/sqle/dtablefunctions/dolt_preview_merge_conflicts_summary.go
Outdated
Show resolved
Hide resolved
Contributor
|
@tbantle22 DOLT
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This table function shows which tables are conflicting between two branches and how many data and/or schema conflicts there are for each table