Skip to content

More precision on the date column in the dolt_diff table#9129

Merged
macneale4 merged 1 commit intomainfrom
macneale4/diff-precision
Apr 18, 2025
Merged

More precision on the date column in the dolt_diff table#9129
macneale4 merged 1 commit intomainfrom
macneale4/diff-precision

Conversation

@macneale4
Copy link
Contributor

Use higher precision date type in the dolt_diff table - matching dolt_diff_{table} now

Fixes: #9126

@coffeegoddd
Copy link
Contributor

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
cfcc6b4 ok 5937457
version total_tests
cfcc6b4 5937457
correctness_percentage
100.0

@macneale4 macneale4 requested a review from fulghum April 18, 2025 17:37
@macneale4 macneale4 marked this pull request as ready for review April 18, 2025 17:37
Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@macneale4 macneale4 merged commit d1dbdb1 into main Apr 18, 2025
34 of 36 checks passed
@macneale4 macneale4 deleted the macneale4/diff-precision branch April 18, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dolt_diff vs dolt_diff_<tablename> - commit time precision differs

3 participants