Skip to content

Prevent unnecessary bytes <-> string conversions and unnecessary allocations when converying to bytes.#9097

Merged
nicktobey merged 2 commits intomainfrom
nicktobey/serial-wrapper
Apr 10, 2025
Merged

Prevent unnecessary bytes <-> string conversions and unnecessary allocations when converying to bytes.#9097
nicktobey merged 2 commits intomainfrom
nicktobey/serial-wrapper

Conversation

@nicktobey
Copy link
Copy Markdown
Contributor

No description provided.

@nicktobey nicktobey force-pushed the nicktobey/serial-wrapper branch from 584c064 to e08c5c7 Compare April 9, 2025 20:12
@nicktobey
Copy link
Copy Markdown
Contributor Author

#benchmark

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2025

@coffeegoddd
Copy link
Copy Markdown
Contributor

@nicktobey DOLT

comparing_percentages
100.000000 to 100.000000
version result total
e08c5c7 ok 5937457
version total_tests
e08c5c7 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Copy Markdown
Contributor

@nicktobey DOLT

test_name from_latency_p95 to_latency_p95 percent_change
tpcc-scale-factor-1 63.32 63.32 0.0
test_name from_server_name from_server_version from_tps to_server_name to_server_version to_tps percent_change
tpcc-scale-factor-1 dolt fc8cd0a 39.46 dolt e08c5c7 39.47 0.03

@coffeegoddd
Copy link
Copy Markdown
Contributor

@nicktobey DOLT

read_tests from_latency to_latency percent_change
covering_index_scan 0.65 0.64 -1.54
groupby_scan 17.63 17.32 -1.76
index_join 2.39 2.35 -1.67
index_join_scan 1.44 1.42 -1.39
index_scan 30.81 30.26 -1.79
oltp_point_select 0.26 0.26 0.0
oltp_read_only 5.18 5.09 -1.74
select_random_points 0.6 0.58 -3.33
select_random_ranges 0.62 0.61 -1.61
table_scan 32.53 31.94 -1.81
types_table_scan 134.9 125.52 -6.95
write_tests from_latency to_latency percent_change
oltp_delete_insert 6.32 6.21 -1.74
oltp_insert 3.07 3.07 0.0
oltp_read_write 11.45 11.24 -1.83
oltp_update_index 3.19 3.13 -1.88
oltp_update_non_index 3.07 3.07 0.0
oltp_write_only 6.32 6.21 -1.74
types_delete_insert 6.67 6.55 -1.8

@nicktobey nicktobey force-pushed the nicktobey/serial-wrapper branch from e08c5c7 to 95fa99d Compare April 9, 2025 22:55
@nicktobey nicktobey changed the title DO NOT SUBMIT benchmark sysbench with optimized ConvertToBytes implementation. Prevent unnecessary bytes <-> string conversions and unnecessary allocations when converying to bytes. Apr 9, 2025
@nicktobey nicktobey force-pushed the nicktobey/serial-wrapper branch from 95fa99d to c4d0cc6 Compare April 9, 2025 23:03
@coffeegoddd
Copy link
Copy Markdown
Contributor

@nicktobey DOLT

comparing_percentages
100.000000 to 100.000000
version result total
c4d0cc6 ok 5937457
version total_tests
c4d0cc6 5937457
correctness_percentage
100.0

@nicktobey nicktobey force-pushed the nicktobey/serial-wrapper branch 2 times, most recently from 021f01e to 286b8ca Compare April 10, 2025 00:27
@coffeegoddd
Copy link
Copy Markdown
Contributor

@nicktobey DOLT

comparing_percentages
100.000000 to 100.000000
version result total
021f01e ok 5937457
version total_tests
021f01e 5937457
correctness_percentage
100.0

@nicktobey nicktobey force-pushed the nicktobey/serial-wrapper branch from 286b8ca to 8c88824 Compare April 10, 2025 00:32
@nicktobey nicktobey force-pushed the nicktobey/serial-wrapper branch from 8c88824 to a110cc3 Compare April 10, 2025 00:33
@nicktobey
Copy link
Copy Markdown
Contributor Author

#benchmark

@github-actions
Copy link
Copy Markdown

@coffeegoddd
Copy link
Copy Markdown
Contributor

@nicktobey DOLT

comparing_percentages
100.000000 to 100.000000
version result total
a110cc3 ok 5937457
version total_tests
a110cc3 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Copy Markdown
Contributor

@nicktobey DOLT

test_name from_latency_p95 to_latency_p95 percent_change
tpcc-scale-factor-1 59.99 59.99 0.0
test_name from_server_name from_server_version from_tps to_server_name to_server_version to_tps percent_change
tpcc-scale-factor-1 dolt 809ba65 39.67 dolt a110cc3 39.79 0.3

@coffeegoddd
Copy link
Copy Markdown
Contributor

@nicktobey DOLT

read_tests from_latency to_latency percent_change
covering_index_scan 0.65 0.67 3.08
groupby_scan 17.63 17.63 0.0
index_join 2.35 2.35 0.0
index_join_scan 1.44 1.44 0.0
index_scan 30.26 30.26 0.0
oltp_point_select 0.26 0.26 0.0
oltp_read_only 5.18 5.18 0.0
select_random_points 0.59 0.6 1.69
select_random_ranges 0.61 0.62 1.64
table_scan 32.53 31.94 -1.81
types_table_scan 134.9 125.52 -6.95
write_tests from_latency to_latency percent_change
oltp_delete_insert 6.32 6.32 0.0
oltp_insert 3.07 3.13 1.95
oltp_read_write 11.45 11.45 0.0
oltp_update_index 3.19 3.19 0.0
oltp_update_non_index 3.07 3.07 0.0
oltp_write_only 6.32 6.32 0.0
types_delete_insert 6.67 6.67 0.0

@nicktobey nicktobey self-assigned this Apr 10, 2025
@coffeegoddd
Copy link
Copy Markdown
Contributor

@nicktobey DOLT

comparing_percentages
100.000000 to 100.000000
version result total
06b6f91 ok 5937457
version total_tests
06b6f91 5937457
correctness_percentage
100.0

@nicktobey nicktobey merged commit 48a7632 into main Apr 10, 2025
21 checks passed
@nicktobey nicktobey deleted the nicktobey/serial-wrapper branch April 10, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants