Skip to content

Don't alter branch head outside of transactions when amending a commit#9075

Merged
macneale4 merged 4 commits intomainfrom
macneale4/amend
Apr 8, 2025
Merged

Don't alter branch head outside of transactions when amending a commit#9075
macneale4 merged 4 commits intomainfrom
macneale4/amend

Conversation

@macneale4
Copy link
Copy Markdown
Contributor

@macneale4 macneale4 commented Apr 4, 2025

Fixes: #9072

@coffeegoddd
Copy link
Copy Markdown
Contributor

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
99c5984 ok 5937457
version total_tests
99c5984 5937457
correctness_percentage
100.0

@macneale4 macneale4 force-pushed the macneale4/amend branch 2 times, most recently from e9633cf to 3ff6346 Compare April 4, 2025 21:33
@macneale4 macneale4 changed the title Don't use HEAD and HEAD~1 when amending commits Don't alter branch head outside of transactions when amending a commit Apr 4, 2025
@coffeegoddd
Copy link
Copy Markdown
Contributor

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
3ff6346 ok 5937457
version total_tests
3ff6346 5937457
correctness_percentage
100.0

@macneale4 macneale4 requested a review from reltuk April 7, 2025 22:48
@macneale4 macneale4 marked this pull request as ready for review April 7, 2025 23:03
@coffeegoddd
Copy link
Copy Markdown
Contributor

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
dc16683 ok 5937457
version total_tests
dc16683 5937457
correctness_percentage
100.0

Copy link
Copy Markdown
Contributor

@reltuk reltuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Definitely an improvement from what we had.

@macneale4 macneale4 merged commit 838a332 into main Apr 8, 2025
21 checks passed
@tbantle22 tbantle22 deleted the macneale4/amend branch May 28, 2025 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Potential concurrency Issue with call dolt_commit('--amend')

3 participants