refactor: use the built-in max/min to simplify the code#9044
Merged
macneale4 merged 1 commit intodolthub:mainfrom Apr 8, 2025
Merged
refactor: use the built-in max/min to simplify the code#9044macneale4 merged 1 commit intodolthub:mainfrom
macneale4 merged 1 commit intodolthub:mainfrom
Conversation
Signed-off-by: evenevent <digping@icloud.com>
Contributor
Author
Thanks for your review. |
Contributor
Author
|
The CI failure seems unrelated to the changes in this PR. Run mheap/github-action-required-labels@v5
with:
mode: exactly
count: 1
labels: correctness_approved
add_comment: true
message: This PR is being tested for SQL correctness. Please allow ~[2](https://github.com/dolthub/dolt/actions/runs/14103799699/job/39939546520#step:2:2)5 mins for this to complete. If this PR does not result in a SQL correctness regression, the `correctness_approved` label will be automatically added to this PR and the `Check for correctness_approved` workflow will succeed.
token: ***
use_regex: false
Error: Resource not accessible by integration |
Contributor
|
Copied into a PR owned by me: #9089 - I have permissions which should help with the CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the built-in max/min from the standard library in Go 1.21 to simplify the code. https://pkg.go.dev/builtin@go1.21.0#max