Skip to content

go: Add some GC lifecycle callbacks to commands which use a local SqlEngine.#9029

Merged
reltuk merged 2 commits intomainfrom
aaron/local-sqlengine-gc-lifecycle-callbacks
Mar 27, 2025
Merged

go: Add some GC lifecycle callbacks to commands which use a local SqlEngine.#9029
reltuk merged 2 commits intomainfrom
aaron/local-sqlengine-gc-lifecycle-callbacks

Conversation

@reltuk
Copy link
Copy Markdown
Contributor

@reltuk reltuk commented Mar 24, 2025

No description provided.

@coffeegoddd
Copy link
Copy Markdown
Contributor

@reltuk DOLT

comparing_percentages
100.000000 to 100.000000
version result total
c651d6e ok 5937457
version total_tests
c651d6e 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Copy Markdown
Contributor

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
c50eaa0 ok 5937457
version total_tests
c50eaa0 5937457
correctness_percentage
100.0

@reltuk reltuk requested a review from zachmu March 25, 2025 19:03
Copy link
Copy Markdown
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reltuk reltuk merged commit bdc0a58 into main Mar 27, 2025
21 of 22 checks passed
@tbantle22 tbantle22 deleted the aaron/local-sqlengine-gc-lifecycle-callbacks branch May 28, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants