Skip to content

go: mvdata: Improve dump, import and export so that these commands create a single SqlEngine over their lifetime.#9023

Merged
reltuk merged 5 commits intomainfrom
aaron/mvdata-sqlengine-creation-fix
Mar 27, 2025
Merged

go: mvdata: Improve dump, import and export so that these commands create a single SqlEngine over their lifetime.#9023
reltuk merged 5 commits intomainfrom
aaron/mvdata-sqlengine-creation-fix

Conversation

@reltuk
Copy link
Copy Markdown
Contributor

@reltuk reltuk commented Mar 24, 2025

Pass the SqlEngine along and reuse it in the operations where we dump table contents, parse import schemas, etc.

@coffeegoddd
Copy link
Copy Markdown
Contributor

coffeegoddd commented Mar 24, 2025

@reltuk DOLT

comparing_percentages
100.000000 to 100.000000
version result total
4cbc789 ok 5937457
version total_tests
4cbc789 5937457
correctness_percentage
100.0

@reltuk reltuk requested a review from zachmu March 25, 2025 19:03
zachmu
zachmu approved these changes Mar 27, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@reltuk reltuk merged commit 01175f7 into main Mar 27, 2025
34 of 35 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Apr 2, 2025
Merged
@tbantle22 tbantle22 deleted the aaron/mvdata-sqlengine-creation-fix branch May 28, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zachmu zachmu zachmu approved these changes

Assignees

No one assigned

Labels

correctness_approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@reltuk @coffeegoddd @zachmu