Bug fix for TypeCompatibilityChecker to ignore ExtenedTypes#8994
Merged
Bug fix for TypeCompatibilityChecker to ignore ExtenedTypes#8994
Conversation
fulghum
force-pushed
the
fulghum/extended_types
branch
from
cb1f006 to
52de437
Compare
fulghum
force-pushed
the
fulghum/extended_types
branch
from
52de437 to
18edfef
Compare
Contributor
nicktobey
approved these changes
Mar 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following query caused a panic in Doltgres, because
DoltTablewas usingTypeCompatibilityCheckerto test if the column type change was compatible.TypeCompatibilityCheckerwasn't able to handle theExtendedTypeinstance and panic'ed. This change makesTypeCompatibilityCheckerignore extended types, since it doesn't know enough about them to determine if a type change is compatible or not.