Skip to content

Root Objects#8965

Merged
Hydrocharged merged 2 commits intomainfrom
daylon/root-objects
Mar 28, 2025
Merged

Root Objects#8965
Hydrocharged merged 2 commits intomainfrom
daylon/root-objects

Conversation

@Hydrocharged
Copy link
Copy Markdown
Contributor

@Hydrocharged Hydrocharged commented Mar 10, 2025

Counterpart to Doltgres PR:

Copy link
Copy Markdown
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly comments about naming and structure, seems like a reasonable draft

@Hydrocharged Hydrocharged force-pushed the daylon/root-objects branch 2 times, most recently from db137fb to 20b10fa Compare March 25, 2025 13:11
@Hydrocharged Hydrocharged changed the title [WIP] Root Objects Root Objects Mar 25, 2025
@Hydrocharged Hydrocharged marked this pull request as ready for review March 25, 2025 13:11
@Hydrocharged Hydrocharged requested a review from zachmu March 25, 2025 13:11
@coffeegoddd
Copy link
Copy Markdown
Contributor

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
7924f36 ok 5937457
version total_tests
7924f36 5937457
correctness_percentage
100.0

@dolthub dolthub deleted a comment from coffeegoddd Mar 27, 2025
@dolthub dolthub deleted a comment from coffeegoddd Mar 27, 2025
@dolthub dolthub deleted a comment from coffeegoddd Mar 27, 2025
@dolthub dolthub deleted a comment from coffeegoddd Mar 27, 2025
@dolthub dolthub deleted a comment from coffeegoddd Mar 27, 2025
@dolthub dolthub deleted a comment from coffeegoddd Mar 27, 2025
@coffeegoddd
Copy link
Copy Markdown
Contributor

@Hydrocharged DOLT

comparing_percentages
100.000000 to 100.000000
version result total
db61ca6 ok 5937457
version total_tests
db61ca6 5937457
correctness_percentage
100.0

@Hydrocharged Hydrocharged merged commit 4b02d92 into main Mar 28, 2025
21 checks passed
@Hydrocharged Hydrocharged deleted the daylon/root-objects branch March 28, 2025 10:42
@github-actions
Copy link
Copy Markdown

@coffeegoddd DOLT

test_name detail row_cnt sorted mysql_time sql_mult cli_mult
batching LOAD DATA 10000 1 0.07 1.29
batching batch sql 10000 1 0.09 1.33
batching by line sql 10000 1 0.09 1.33
blob 1 blob 200000 1 0.93 3.78 4.45
blob 2 blobs 200000 1 0.9 4.36 4.73
blob no blob 200000 1 1 2.22 2.63
col type datetime 200000 1 0.83 2.47 2.8
col type varchar 200000 1 0.7 3.49 3.8
config width 2 cols 200000 1 0.85 2.41 2.72
config width 32 cols 200000 1 1.91 2.01 2.73
config width 8 cols 200000 1 0.98 2.39 2.7
pk type float 200000 1 0.83 2.47 2.84
pk type int 200000 1 0.83 2.46 2.76
pk type varchar 200000 1 1.46 1.77 1.93
row count 1.6mm 1600000 1 5.57 3.07 3.15
row count 400k 400000 1 1.57 2.65 2.85
row count 800k 800000 1 2.81 3.03 3.16
secondary index four index 200000 1 3.64 1.42 1.31
secondary index no secondary 200000 1 0.94 2.35 2.77
secondary index one index 200000 1 1.18 2.4 2.5
secondary index two index 200000 1 2.08 1.71 1.82
sorting shuffled 1mm 1000000 0 5.42 2.76 2.66
sorting sorted 1mm 1000000 1 5.34 2.81 2.71

@github-actions
Copy link
Copy Markdown

@coffeegoddd DOLT

name detail mean_mult
dolt_blame_basic system table 1.18
dolt_blame_commit_filter system table 2.89
dolt_commit_ancestors_commit_filter system table 0.65
dolt_commits_commit_filter system table 1.05
dolt_diff_log_join_from_commit system table 2.78
dolt_diff_log_join_to_commit system table 2.74
dolt_diff_table_from_commit_filter system table 1.19
dolt_diff_table_to_commit_filter system table 1.17
dolt_diffs_commit_filter system table 1.06
dolt_history_commit_filter system table 1.5
dolt_log_commit_filter system table 1.05

@github-actions
Copy link
Copy Markdown

@coffeegoddd DOLT

name add_cnt delete_cnt update_cnt latency
adds_only 60000 0 0 1.14
adds_updates_deletes 60000 60000 60000 4.6
deletes_only 0 60000 0 2.5
updates_only 0 0 60000 3.11

@github-actions
Copy link
Copy Markdown

@coffeegoddd DOLT

test_name detail row_cnt sorted mysql_time sql_mult cli_mult
batching LOAD DATA 10000 1 0.06 1.5
batching batch sql 10000 1 0.11 1.09
batching by line sql 10000 1 0.1 1.2
blob 1 blob 200000 1 0.94 3.7 4.43
blob 2 blobs 200000 1 0.91 4.31 4.76
blob no blob 200000 1 0.98 2.27 2.66
col type datetime 200000 1 0.81 2.51 2.89
col type varchar 200000 1 0.85 2.82 3.13
config width 2 cols 200000 1 0.85 2.41 2.74
config width 32 cols 200000 1 1.85 2.06 2.81
config width 8 cols 200000 1 0.95 2.49 2.78
pk type float 200000 1 0.85 2.39 2.82
pk type int 200000 1 0.84 2.42 2.75
pk type varchar 200000 1 1.5 1.77 2.19
row count 1.6mm 1600000 1 5.86 2.94 2.99
row count 400k 400000 1 1.51 2.75 2.94
row count 800k 800000 1 2.95 2.86 2.97
secondary index four index 200000 1 3.75 1.38 1.28
secondary index no secondary 200000 1 0.96 2.32 2.73
secondary index one index 200000 1 1.19 2.36 2.45
secondary index two index 200000 1 2.08 1.74 1.84
sorting shuffled 1mm 1000000 0 5.25 2.83 2.66
sorting sorted 1mm 1000000 1 5.11 2.91 2.89

@github-actions
Copy link
Copy Markdown

@coffeegoddd DOLT

name detail mean_mult
dolt_blame_basic system table 1.17
dolt_blame_commit_filter system table 2.92
dolt_commit_ancestors_commit_filter system table 0.65
dolt_commits_commit_filter system table 1.11
dolt_diff_log_join_from_commit system table 2.75
dolt_diff_log_join_to_commit system table 2.71
dolt_diff_table_from_commit_filter system table 1.25
dolt_diff_table_to_commit_filter system table 1.14
dolt_diffs_commit_filter system table 1.03
dolt_history_commit_filter system table 1.44
dolt_log_commit_filter system table 1.05

@github-actions
Copy link
Copy Markdown

@coffeegoddd DOLT

name add_cnt delete_cnt update_cnt latency
adds_only 60000 0 0 1.14
adds_updates_deletes 60000 60000 60000 4.64
deletes_only 0 60000 0 2.49
updates_only 0 0 60000 3.09

@github-actions
Copy link
Copy Markdown

@coffeegoddd DOLT

test_name detail row_cnt sorted mysql_time sql_mult cli_mult
batching LOAD DATA 10000 1 0.06 1.5
batching batch sql 10000 1 0.08 1.5
batching by line sql 10000 1 0.09 1.33
blob 1 blob 200000 1 0.92 3.79 4.53
blob 2 blobs 200000 1 0.91 4.32 4.67
blob no blob 200000 1 0.96 2.3 2.73
col type datetime 200000 1 0.79 2.53 2.9
col type varchar 200000 1 0.69 3.41 3.86
config width 2 cols 200000 1 0.87 2.31 2.64
config width 32 cols 200000 1 1.88 2.04 2.77
config width 8 cols 200000 1 1.04 2.26 2.55
pk type float 200000 1 0.85 2.39 2.73
pk type int 200000 1 0.9 2.4 2.49
pk type varchar 200000 1 1.48 1.74 2.02
row count 1.6mm 1600000 1 5.72 3 3.02
row count 400k 400000 1 1.46 2.83 2.99
row count 800k 800000 1 2.87 2.96 3.03
secondary index four index 200000 1 3.56 1.44 1.35
secondary index no secondary 200000 1 1.03 2.16 2.53
secondary index one index 200000 1 1.15 2.44 2.52
secondary index two index 200000 1 2.06 1.72 1.84
sorting shuffled 1mm 1000000 0 5.04 2.93 2.79
sorting sorted 1mm 1000000 1 5.2 2.83 2.72

@github-actions
Copy link
Copy Markdown

@coffeegoddd DOLT

name detail mean_mult
dolt_blame_basic system table 1.17
dolt_blame_commit_filter system table 2.92
dolt_commit_ancestors_commit_filter system table 0.65
dolt_commits_commit_filter system table 1.05
dolt_diff_log_join_from_commit system table 2.75
dolt_diff_log_join_to_commit system table 2.74
dolt_diff_table_from_commit_filter system table 1.22
dolt_diff_table_to_commit_filter system table 1.2
dolt_diffs_commit_filter system table 1
dolt_history_commit_filter system table 1.58
dolt_log_commit_filter system table 1.05

@github-actions
Copy link
Copy Markdown

@coffeegoddd DOLT

name add_cnt delete_cnt update_cnt latency
adds_only 60000 0 0 1.11
adds_updates_deletes 60000 60000 60000 4.57
deletes_only 0 60000 0 2.45
updates_only 0 0 60000 3.04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants