Skip to content

store/nbs: s3_object_reader: Fix a regression which prevented loading large table files with the AWS NomsBlockStore backend.#8963

Merged
reltuk merged 2 commits intomainfrom
aaron/store-nbs-s3objectreader-fix-large-table-files-regression
Mar 10, 2025
Merged

store/nbs: s3_object_reader: Fix a regression which prevented loading large table files with the AWS NomsBlockStore backend.#8963
reltuk merged 2 commits intomainfrom
aaron/store-nbs-s3objectreader-fix-large-table-files-regression

Conversation

@reltuk
Copy link
Copy Markdown
Contributor

@reltuk reltuk commented Mar 8, 2025

Affects 1.50.0, 1.50.1 and 1.50.2.

… large table files with the AWS NomsBlockStore backend.

Affects 1.50.0, 1.50.1 and 1.50.2.
@reltuk reltuk marked this pull request as ready for review March 8, 2025 02:07
@reltuk reltuk requested a review from macneale4 March 8, 2025 02:09
@coffeegoddd
Copy link
Copy Markdown
Contributor

@reltuk DOLT

comparing_percentages
100.000000 to 100.000000
version result total
d1a76fb ok 5937457
version total_tests
d1a76fb 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Copy Markdown
Contributor

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
2812d02 ok 5937457
version total_tests
2812d02 5937457
correctness_percentage
100.0

@reltuk reltuk merged commit e541090 into main Mar 10, 2025
21 of 22 checks passed
@tbantle22 tbantle22 deleted the aaron/store-nbs-s3objectreader-fix-large-table-files-regression branch May 28, 2025 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants