Skip to content

go: cmd/dolt: sqlserver: Create a Config struct to encapsulate arguments that control sqlserver.ConfigureServices behavior.#8950

Merged
reltuk merged 1 commit intomainfrom
aaron/sqlserver-config
Mar 6, 2025
Merged

go: cmd/dolt: sqlserver: Create a Config struct to encapsulate arguments that control sqlserver.ConfigureServices behavior.#8950
reltuk merged 1 commit intomainfrom
aaron/sqlserver-config

Conversation

@reltuk
Copy link
Copy Markdown
Contributor

@reltuk reltuk commented Mar 5, 2025

Allow configuring the ProtocolListenerFactory through ConfigureServices.

@reltuk
go: cmd/dolt: sqlserver: Create a Config struct to encapsulate argume…
60cbf47 
…nts that control sqlserver.ConfigureServices behavior.

Allow configuring the ProtocolListenerFactory through ConfigureServices.
zachmu
zachmu approved these changes Mar 6, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coffeegoddd
Copy link
Copy Markdown
Contributor

coffeegoddd commented Mar 6, 2025

@reltuk DOLT

comparing_percentages
100.000000 to 100.000000
version result total
60cbf47 ok 5937457
version total_tests
60cbf47 5937457
correctness_percentage
100.0

@reltuk reltuk merged commit 757a7c6 into main Mar 6, 2025
34 of 35 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Mar 11, 2025
Merged
@tbantle22 tbantle22 deleted the aaron/sqlserver-config branch May 28, 2025 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zachmu zachmu zachmu approved these changes

Assignees

No one assigned

Labels

correctness_approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@reltuk @coffeegoddd @zachmu