Skip to content

go: cmd/dolt: sqlserver: When stopping the svcs.Controller for the sql-server, drain client connections so that the handler is guaranteed to no longer be handling any connections when the server is stopped.#8948

Merged
reltuk merged 1 commit intomainfrom
aaron/sqlserver-wait-for-connection-drain
Mar 5, 2025

Conversation

@reltuk
Copy link
Copy Markdown
Contributor

@reltuk reltuk commented Mar 5, 2025

No description provided.

…l-server, drain client connections so that the handler is guaranteed to no longer be handling any connections when the server is stopped.
Copy link
Copy Markdown
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coffeegoddd
Copy link
Copy Markdown
Contributor

@reltuk DOLT

comparing_percentages
100.000000 to 100.000000
version result total
aa669b9 ok 5937457
version total_tests
aa669b9 5937457
correctness_percentage
100.0

@reltuk reltuk merged commit 34d807a into main Mar 5, 2025
34 of 35 checks passed
@tbantle22 tbantle22 deleted the aaron/sqlserver-wait-for-connection-drain branch May 28, 2025 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants