chore: added log_format for auto_generated yaml#8941
Conversation
timsehn
left a comment
There was a problem hiding this comment.
I don't think this covers it all. I think this only adds documentation in the dolt sql-server command.
That's great and we can definitely take this as a PR.
But to add the log_format to the auto-generated file I believe requires more code as seen in this PR:
https://github.com/dolthub/dolt/pull/8644/files
But if I'm wrong, add log_format to the auto-generated test in server_test.go and prove it to me:
go/cmd/dolt/commands/sqlserver/server_test.go
|
@timsehn I have check over my local build and It is already present in auto-generated test : |
|
Huh. Weird I missed that. |
|
Change looks good assuming the final CI checks pass. |
|
@coffeegoddd DOLT
|
|
@coffeegoddd DOLT
|
|
@coffeegoddd DOLT
|
Added log_format in sqlserver.go to automate addition of log_format in config