Skip to content

chore: added log_format for auto_generated yaml#8941

Merged
zachmu merged 1 commit intodolthub:mainfrom
dds05:automate/log_format
Mar 6, 2025
Merged

chore: added log_format for auto_generated yaml#8941
zachmu merged 1 commit intodolthub:mainfrom
dds05:automate/log_format

Conversation

@dds05
Copy link
Copy Markdown
Contributor

@dds05 dds05 commented Mar 5, 2025

Added log_format in sqlserver.go to automate addition of log_format in config

@dds05
Copy link
Copy Markdown
Contributor Author

dds05 commented Mar 5, 2025

@timsehn

Copy link
Copy Markdown
Contributor

@timsehn timsehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this covers it all. I think this only adds documentation in the dolt sql-server command.

That's great and we can definitely take this as a PR.

But to add the log_format to the auto-generated file I believe requires more code as seen in this PR:

https://github.com/dolthub/dolt/pull/8644/files
But if I'm wrong, add log_format to the auto-generated test in server_test.go and prove it to me:

go/cmd/dolt/commands/sqlserver/server_test.go

@dds05
Copy link
Copy Markdown
Contributor Author

dds05 commented Mar 5, 2025

@timsehn I have check over my local build and log_format is getting added in the generated .yaml.

It is already present in auto-generated test : go/cmd/dolt/commands/sqlserver/server_test.go

@dds05 dds05 requested a review from timsehn March 5, 2025 19:34
@timsehn
Copy link
Copy Markdown
Contributor

timsehn commented Mar 5, 2025

Huh. Weird I missed that.

@zachmu
Copy link
Copy Markdown
Member

zachmu commented Mar 5, 2025

Change looks good assuming the final CI checks pass.

@zachmu zachmu merged commit 8a3d3fb into dolthub:main Mar 6, 2025
32 of 35 checks passed
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 6, 2025

@coffeegoddd DOLT

test_name detail row_cnt sorted mysql_time sql_mult cli_mult
batching LOAD DATA 10000 1 0.07 1.14
batching batch sql 10000 1 0.11 1.09
batching by line sql 10000 1 0.12 1.08
blob 1 blob 200000 1 0.94 3.69 4.36
blob 2 blobs 200000 1 0.91 4.33 4.64
blob no blob 200000 1 0.98 2.27 2.61
col type datetime 200000 1 0.81 2.47 2.78
col type varchar 200000 1 0.75 3.19 3.49
config width 2 cols 200000 1 0.86 2.35 3.76
config width 32 cols 200000 1 1.94 1.93 2.65
config width 8 cols 200000 1 0.97 2.4 2.94
pk type float 200000 1 0.83 2.47 2.75
pk type int 200000 1 1.06 1.88 2.13
pk type varchar 200000 1 1.48 1.76 1.86
row count 1.6mm 1600000 1 5.78 2.93 2.89
row count 400k 400000 1 1.49 2.76 2.8
row count 800k 800000 1 2.95 2.84 2.84
secondary index four index 200000 1 3.66 1.37 1.28
secondary index no secondary 200000 1 0.96 2.3 2.68
secondary index one index 200000 1 1.19 2.33 2.45
secondary index two index 200000 1 2.09 1.69 1.77
sorting shuffled 1mm 1000000 0 5.27 2.83 2.69
sorting sorted 1mm 1000000 1 5.45 2.74 2.59

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 6, 2025

@coffeegoddd DOLT

name detail mean_mult
dolt_blame_basic system table 1.2
dolt_blame_commit_filter system table 3.01
dolt_commit_ancestors_commit_filter system table 0.63
dolt_commits_commit_filter system table 1.05
dolt_diff_log_join_from_commit system table 2.67
dolt_diff_log_join_to_commit system table 2.6
dolt_diff_table_from_commit_filter system table 1.11
dolt_diff_table_to_commit_filter system table 1.14
dolt_diffs_commit_filter system table 1.03
dolt_history_commit_filter system table 1.33
dolt_log_commit_filter system table 1.05

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 6, 2025

@coffeegoddd DOLT

name add_cnt delete_cnt update_cnt latency
adds_only 60000 0 0 1.12
adds_updates_deletes 60000 60000 60000 4.61
deletes_only 0 60000 0 2.46
updates_only 0 0 60000 3.06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants