Skip to content

go: Bump to go 1.24. Fix some vet errors related to non-constant format strings.#8897

Merged
reltuk merged 4 commits intomainfrom
aaron/go-1.24
Feb 27, 2025
Merged

go: Bump to go 1.24. Fix some vet errors related to non-constant format strings.#8897
reltuk merged 4 commits intomainfrom
aaron/go-1.24

Conversation

@reltuk
Copy link
Copy Markdown
Contributor

@reltuk reltuk commented Feb 26, 2025

No description provided.

@reltuk reltuk requested a review from coffeegoddd February 26, 2025 23:02
@coffeegoddd
Copy link
Copy Markdown
Contributor

@reltuk DOLT

comparing_percentages
100.000000 to 100.000000
version result total
03510f5 ok 5937457
version total_tests
03510f5 5937457
correctness_percentage
100.0

@reltuk
Copy link
Copy Markdown
Contributor Author

reltuk commented Feb 27, 2025

#benchmark

@github-actions
Copy link
Copy Markdown

@coffeegoddd
Copy link
Copy Markdown
Contributor

@reltuk DOLT

test_name from_latency_p95 to_latency_p95 percent_change
tpcc-scale-factor-1 59.99 59.99 0.0
test_name from_server_name from_server_version from_tps to_server_name to_server_version to_tps percent_change
tpcc-scale-factor-1 dolt ab7b558 40.14 dolt 03510f5 39.92 -0.55

@coffeegoddd
Copy link
Copy Markdown
Contributor

@reltuk DOLT

read_tests from_latency to_latency percent_change
covering_index_scan 0.64 0.64 0.0
groupby_scan 18.28 17.95 -1.81
index_join 2.57 2.57 0.0
index_join_scan 1.5 1.47 -2.0
index_scan 30.81 30.26 -1.79
oltp_point_select 0.27 0.26 -3.7
oltp_read_only 5.28 5.28 0.0
select_random_points 0.6 0.6 0.0
select_random_ranges 0.62 0.61 -1.61
table_scan 33.12 31.37 -5.28
types_table_scan 114.72 110.66 -3.54
write_tests from_latency to_latency percent_change
oltp_delete_insert 6.32 6.32 0.0
oltp_insert 3.13 3.13 0.0
oltp_read_write 11.65 11.65 0.0
oltp_update_index 3.19 3.19 0.0
oltp_update_non_index 3.13 3.13 0.0
oltp_write_only 6.43 6.32 -1.71
types_delete_insert 6.67 6.67 0.0

@reltuk reltuk merged commit 1b0f660 into main Feb 27, 2025
21 of 22 checks passed
@github-actions
Copy link
Copy Markdown

@coffeegoddd DOLT

test_name detail row_cnt sorted mysql_time sql_mult cli_mult
batching LOAD DATA 10000 1 0.07 1.29
batching batch sql 10000 1 0.09 1.33
batching by line sql 10000 1 0.11 1.09
blob 1 blob 200000 1 0.93 3.77 4.53
blob 2 blobs 200000 1 0.93 4.29 4.59
blob no blob 200000 1 1.06 2.1 2.43
col type datetime 200000 1 0.85 2.39 2.65
col type varchar 200000 1 0.77 3.22 3.47
config width 2 cols 200000 1 0.84 2.42 2.7
config width 32 cols 200000 1 1.91 2 2.79
config width 8 cols 200000 1 0.98 2.45 2.88
pk type float 200000 1 0.87 2.33 2.7
pk type int 200000 1 0.86 2.36 2.63
pk type varchar 200000 1 2.96 0.86 0.95
row count 1.6mm 1600000 1 5.68 3 2.96
row count 400k 400000 1 1.59 2.6 2.72
row count 800k 800000 1 2.86 2.95 2.96
secondary index four index 200000 1 3.75 1.35 1.25
secondary index no secondary 200000 1 0.95 2.35 2.72
secondary index one index 200000 1 1.15 2.4 2.52
secondary index two index 200000 1 2.07 1.73 1.79
sorting shuffled 1mm 1000000 0 5.68 2.72 2.76
sorting sorted 1mm 1000000 1 5.62 2.78 2.78

@github-actions
Copy link
Copy Markdown

@coffeegoddd DOLT

name detail mean_mult
dolt_blame_basic system table 1.21
dolt_blame_commit_filter system table 3
dolt_commit_ancestors_commit_filter system table 0.66
dolt_commits_commit_filter system table 1.1
dolt_diff_log_join_from_commit system table 2.78
dolt_diff_log_join_to_commit system table 2.74
dolt_diff_table_from_commit_filter system table 1.18
dolt_diff_table_to_commit_filter system table 1.11
dolt_diffs_commit_filter system table 1.06
dolt_history_commit_filter system table 1.24
dolt_log_commit_filter system table 1.11

@github-actions
Copy link
Copy Markdown

@coffeegoddd DOLT

name add_cnt delete_cnt update_cnt latency
adds_only 60000 0 0 1.11
adds_updates_deletes 60000 60000 60000 4.63
deletes_only 0 60000 0 2.44
updates_only 0 0 60000 3.03

@tbantle22 tbantle22 deleted the aaron/go-1.24 branch May 28, 2025 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants