Skip to content

[stats] Rewrite stat management to use single threaded event loop#8815

Merged
max-hoffman merged 149 commits intomainfrom
max/stats-event-loop
Mar 20, 2025
Merged

[stats] Rewrite stat management to use single threaded event loop#8815
max-hoffman merged 149 commits intomainfrom
max/stats-event-loop

Conversation

@max-hoffman
Copy link
Copy Markdown
Contributor

@max-hoffman max-hoffman commented Feb 4, 2025

Reference statspro/doc.go for more detailed overview. Replaced stats management with a worker->scheduler->executer system. Worker does the default background job organizing, scheduler serializes background and async requests, executor calls function callbacks with a ticker delay. GC performed within a loop.

Early perf testing seems to have little/no impact on TPC-C when the job ticker is 100-500ms.

fixes: #8844

@coffeegoddd
Copy link
Copy Markdown
Contributor

@max-hoffman DOLT

comparing_percentages
100.000000 to 100.000000
version result total
91f0cf6 ok 5937457
version total_tests
91f0cf6 5937457
correctness_percentage
100.0

@max-hoffman
Copy link
Copy Markdown
Contributor Author

#benchmark

@github-actions
Copy link
Copy Markdown

@coffeegoddd
Copy link
Copy Markdown
Contributor

@max-hoffman DOLT

comparing_percentages
100.000000 to 100.000000
version result total
de47ba3 ok 5937457
version total_tests
de47ba3 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Copy Markdown
Contributor

@max-hoffman DOLT

comparing_percentages
100.000000 to 100.000000
version result total
2a75378 ok 5937457
version total_tests
2a75378 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Copy Markdown
Contributor

@max-hoffman DOLT

comparing_percentages
100.000000 to 100.000000
version result total
4d0bab5 ok 5937457
version total_tests
4d0bab5 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Copy Markdown
Contributor

@max-hoffman DOLT

comparing_percentages
100.000000 to 100.000000
version result total
05bcf2c ok 5937457
version total_tests
05bcf2c 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Copy Markdown
Contributor

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
c701726 ok 5937457
version total_tests
c701726 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Copy Markdown
Contributor

@max-hoffman DOLT

comparing_percentages
100.000000 to 100.000000
version result total
a4d4f72 ok 5937457
version total_tests
a4d4f72 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Copy Markdown
Contributor

@max-hoffman DOLT

comparing_percentages
100.000000 to 100.000000
version result total
252efd0 ok 5937457
version total_tests
252efd0 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Copy Markdown
Contributor

@max-hoffman DOLT

comparing_percentages
100.000000 to 100.000000
version result total
bc7f15a ok 5937457
version total_tests
bc7f15a 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Copy Markdown
Contributor

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
73fcedc ok 5937457
version total_tests
73fcedc 5937457
correctness_percentage
100.0

@max-hoffman max-hoffman merged commit b8b2ff1 into main Mar 20, 2025
20 of 21 checks passed
@tbantle22 tbantle22 deleted the max/stats-event-loop branch May 28, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Panic from vector index (possibly from stats)

4 participants