Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a databasename parameter to the DoltDBFromCS #8540

Merged
merged 2 commits into from
Nov 7, 2024
Merged

add a databasename parameter to the DoltDBFromCS #8540

merged 2 commits into from
Nov 7, 2024

Conversation

liuliu-dev
Copy link
Contributor

No description provided.

zachmu
zachmu approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coffeegoddd
Copy link
Contributor

@liuliu-dev DOLT

comparing_percentages
100.000000 to 100.000000
version result total
3860cca ok 5937457
version total_tests
3860cca 5937457
correctness_percentage
100.0

@liuliu-dev liuliu-dev merged commit e0bb687 into main Nov 7, 2024
21 of 22 checks passed
@liuliu-dev liuliu-dev deleted the liuliu/pass-databaseName-to-DoltDBFromCS branch November 7, 2024 19:14
@liuliu-dev liuliu-dev changed the title liuliu/pass-databaseName-to-DoltDBFromCS add a databasename parameter to the DoltDBFromCS Nov 7, 2024
@BrewTestBot BrewTestBot mentioned this pull request Nov 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liuliu-dev @coffeegoddd @zachmu