Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multiple schema for system tables with $tablename for doltgres #8527

Merged
merged 5 commits into from
Nov 7, 2024
Merged

Support multiple schema for system tables with $tablename for doltgres #8527

merged 5 commits into from
Nov 7, 2024

Conversation

tbantle22
Copy link
Contributor

No description provided.

@tbantle22 tbantle22 mentioned this pull request Nov 5, 2024
Merged
@coffeegoddd
Copy link
Contributor

@tbantle22 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
3168e4e ok 5937457
version total_tests
3168e4e 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@tbantle22 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
f426cb0 ok 5937457
version total_tests
f426cb0 5937457
correctness_percentage
100.0

@tbantle22 tbantle22 requested a review from zachmu November 6, 2024 01:04
@tbantle22 tbantle22 marked this pull request as ready for review November 6, 2024 01:04
zachmu
zachmu approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great except for the table resolution method, see notes

go/libraries/doltcore/sqle/database.go Outdated Show resolved Hide resolved
go/libraries/doltcore/sqle/database.go Outdated Show resolved Hide resolved
go/libraries/doltcore/sqle/dtables/diff_table.go Outdated Show resolved Hide resolved
zachmu
zachmu approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coffeegoddd
Copy link
Contributor

@tbantle22 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
eba40a9 ok 5937457
version total_tests
eba40a9 5937457
correctness_percentage
100.0

@tbantle22 tbantle22 merged commit 5fb8fb1 into main Nov 7, 2024
21 checks passed
@tbantle22 tbantle22 deleted the taylor/pref-dtables branch November 7, 2024 18:18
This was referenced Nov 9, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tbantle22 @coffeegoddd @zachmu