Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update more system tables for doltgres #8508

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Update more system tables for doltgres #8508

merged 2 commits into from
Oct 30, 2024

Conversation

tbantle22
Copy link
Contributor

No description provided.

@coffeegoddd
Copy link
Contributor

@tbantle22 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
dd4bc3a ok 5937457
version total_tests
dd4bc3a 5937457
correctness_percentage
100.0

@tbantle22 tbantle22 marked this pull request as ready for review October 30, 2024 19:17
@tbantle22 tbantle22 requested a review from zachmu October 30, 2024 19:20
@coffeegoddd
Copy link
Contributor

@tbantle22 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
2fbdd5b ok 5937457
version total_tests
2fbdd5b 5937457
correctness_percentage
100.0

zachmu
zachmu approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice job

@tbantle22 tbantle22 merged commit 1035f4f into main Oct 30, 2024
21 checks passed
@tbantle22 tbantle22 deleted the taylor/read-dtables branch October 30, 2024 22:23
@BrewTestBot BrewTestBot mentioned this pull request Oct 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tbantle22 @coffeegoddd @zachmu