Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panics on schema changes #8505

Merged
merged 7 commits into from
Oct 30, 2024
Merged

Fix panics on schema changes #8505

merged 7 commits into from
Oct 30, 2024

Conversation

max-hoffman
Copy link
Contributor

@max-hoffman max-hoffman commented Oct 29, 2024

fixes: #8504

Use schema hash to detect when database statistics might be incompatible. Drops all statistics for schema update. This could be improved to a subset of statistics if we wanted in the future.

@coffeegoddd
Copy link
Contributor

@max-hoffman DOLT

comparing_percentages
100.000000 to 100.000000
version result total
f049f9a ok 5937457
version total_tests
f049f9a 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@max-hoffman DOLT

comparing_percentages
100.000000 to 100.000000
version result total
b433c92 ok 5937457
version total_tests
b433c92 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@max-hoffman DOLT

comparing_percentages
100.000000 to 100.000000
version result total
3e50120 ok 5937457
version total_tests
3e50120 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@max-hoffman DOLT

comparing_percentages
100.000000 to 100.000000
version result total
a8c42da ok 5937457
version total_tests
a8c42da 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@max-hoffman DOLT

comparing_percentages
100.000000 to 100.000000
version result total
bd30b7c ok 5937457
version total_tests
bd30b7c 5937457
correctness_percentage
100.0

@max-hoffman max-hoffman merged commit 1144c7f into main Oct 30, 2024
21 checks passed
@max-hoffman max-hoffman deleted the max/stats-schema-changes branch October 30, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when refreshing statistics after a PK column change
3 participants