Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fixes for replication #8501

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Bug fixes for replication #8501

merged 1 commit into from
Oct 28, 2024
+18 −7

Conversation

fulghum
Copy link
Contributor

@fulghum fulghum commented Oct 28, 2024

  • Convert @@server_id to uint32 value when it gets loaded as a string from config.json
  • Send binary logfile name in server heartbeat events, now required in MySQL 8.4

@fulghum
Bug fixes for replication: converting server_id to uint32 when it get…
e197477 
…s loaded as a string from config.json, sending binary logfile name in server heartbeats, now required in MySQL 8.4
@coffeegoddd
Copy link
Contributor

@fulghum DOLT

comparing_percentages
100.000000 to 100.000000
version result total
e197477 ok 5937457
version total_tests
e197477 5937457
correctness_percentage
100.0

@fulghum fulghum requested a review from jycor October 28, 2024 18:55
jycor
jycor approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@jycor jycor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fulghum fulghum merged commit 1d97bd2 into main Oct 28, 2024
34 of 35 checks passed
@fulghum fulghum deleted the fulghum/binlog-fixes branch October 28, 2024 19:06
@BrewTestBot BrewTestBot mentioned this pull request Oct 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jycor jycor jycor approved these changes

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fulghum @coffeegoddd @jycor