Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move dolt system tables to dolt schema for doltgres #8482

Merged
merged 10 commits into from
Oct 28, 2024
Merged

Conversation

tbantle22
Copy link
Contributor

No description provided.

@coffeegoddd
Copy link
Contributor

@tbantle22 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
6ea86b0 ok 5937457
version total_tests
6ea86b0 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@tbantle22 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
e20f216 ok 5937457
version total_tests
e20f216 5937457
correctness_percentage
100.0

@tbantle22 tbantle22 changed the title Move dolt_docs to dolt schema for doltgres Move dolt system tables to dolt schema for doltgres Oct 24, 2024
@coffeegoddd
Copy link
Contributor

@tbantle22 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
725d752 ok 5937457
version total_tests
725d752 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@tbantle22 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
64e2692 ok 5937457
version total_tests
64e2692 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@tbantle22 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
0809357 ok 5937457
version total_tests
0809357 5937457
correctness_percentage
100.0

@tbantle22 tbantle22 marked this pull request as ready for review October 25, 2024 16:51
@tbantle22 tbantle22 requested a review from zachmu October 25, 2024 16:54
@coffeegoddd
Copy link
Contributor

@tbantle22 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
674d29f ok 5937457
version total_tests
674d29f 5937457
correctness_percentage
100.0

go/libraries/doltcore/sqle/database.go Outdated Show resolved Hide resolved
go/libraries/doltcore/sqle/database.go Outdated Show resolved Hide resolved
go/libraries/doltcore/sqle/database.go Outdated Show resolved Hide resolved
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a couple caveats.

There's also some logic and a comment in Database.resolveUserTable that should now be cleaned up.

@coffeegoddd
Copy link
Contributor

@tbantle22 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
ad541d7 ok 5937457
version total_tests
ad541d7 5937457
correctness_percentage
100.0

Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, couple notes

go/libraries/doltcore/sqle/resolve/search_path.go Outdated Show resolved Hide resolved
go/libraries/doltcore/sqle/resolve/search_path.go Outdated Show resolved Hide resolved
go/libraries/doltcore/sqle/resolve/search_path.go Outdated Show resolved Hide resolved
go/libraries/doltcore/sqle/resolve/search_path.go Outdated Show resolved Hide resolved
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple final small comments

go/libraries/doltcore/sqle/database.go Outdated Show resolved Hide resolved
go/libraries/doltcore/sqle/database.go Outdated Show resolved Hide resolved
@coffeegoddd
Copy link
Contributor

@tbantle22 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
ac54d05 ok 5937457
version total_tests
ac54d05 5937457
correctness_percentage
100.0

@tbantle22 tbantle22 merged commit 746ebc6 into main Oct 28, 2024
20 of 21 checks passed
@tbantle22 tbantle22 deleted the taylor/dolt-schema branch October 28, 2024 19:59
Copy link

@coffeegoddd DOLT

test_name detail row_cnt sorted mysql_time sql_mult cli_mult
batching LOAD DATA 10000 1 0.06 1.33
batching batch sql 10000 1 0.08 1.5
batching by line sql 10000 1 0.09 1.33
blob 1 blob 200000 1 0.92 3.59 3.42
blob 2 blobs 200000 1 0.9 4.11 4.27
blob no blob 200000 1 0.9 2.26 1.97
col type datetime 200000 1 0.84 2.81 2.68
col type varchar 200000 1 0.68 3.22 2.76
config width 2 cols 200000 1 0.95 1.97 1.61
config width 32 cols 200000 1 1.92 2.08 2.14
config width 8 cols 200000 1 0.98 2.21 2.84
pk type float 200000 1 0.86 2.2 1.81
pk type int 200000 1 0.8 2.33 1.89
pk type varchar 200000 1 1.54 1.59 1.33
row count 1.6mm 1600000 1 5.55 2.81 2.26
row count 400k 400000 1 1.45 2.63 2.12
row count 800k 800000 1 2.85 2.71 2.19
secondary index four index 200000 1 3.46 1.36 1.07
secondary index no secondary 200000 1 0.91 2.25 1.93
secondary index one index 200000 1 1.12 2.31 1.88
secondary index two index 200000 1 1.96 1.66 1.38
sorting shuffled 1mm 1000000 0 4.99 2.72 2.26
sorting sorted 1mm 1000000 1 4.94 2.73 2.26

Copy link

@coffeegoddd DOLT

name detail mean_mult
dolt_blame_basic system table 1.13
dolt_blame_commit_filter system table 2.91
dolt_commit_ancestors_commit_filter system table 0.65
dolt_commits_commit_filter system table 1.05
dolt_diff_log_join_from_commit system table 2.06
dolt_diff_log_join_to_commit system table 2.09
dolt_diff_table_from_commit_filter system table 1.2
dolt_diff_table_to_commit_filter system table 1.23
dolt_diffs_commit_filter system table 1
dolt_history_commit_filter system table 1.28
dolt_log_commit_filter system table 1.16

Copy link

@coffeegoddd DOLT

name add_cnt delete_cnt update_cnt latency
adds_only 60000 0 0 0.71
adds_updates_deletes 60000 60000 60000 3.83
deletes_only 0 60000 0 1.9
updates_only 0 0 60000 2.43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants