Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

turn on stats collect by default #8453

Merged
merged 13 commits into from
Oct 24, 2024
Merged

turn on stats collect by default #8453

merged 13 commits into from
Oct 24, 2024

Conversation

max-hoffman
Copy link
Contributor

No description provided.

@max-hoffman
Copy link
Contributor Author

#benchmark

@github-actions GitHub Actions
Copy link

@max-hoffman workflow run: https://github.com/dolthub/dolt/actions/runs/11351423446

@coffeegoddd
Copy link
Contributor

@max-hoffman DOLT

comparing_percentages
100.000000 to 100.000000
version result total
26010b7 ok 5937457
version total_tests
26010b7 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@max-hoffman DOLT

test_name from_latency_p95 to_latency_p95 percent_change
tpcc-scale-factor-1 64.47 62.19 -3.54
test_name from_server_name from_server_version from_tps to_server_name to_server_version to_tps percent_change
tpcc-scale-factor-1 dolt d1eb0cd 40.42 dolt 26010b7 40.73 0.77

@coffeegoddd
Copy link
Contributor

@max-hoffman DOLT

read_tests from_latency to_latency percent_change
covering_index_scan 0.63 0.63 0.0
groupby_scan 16.71 16.71 0.0
index_join 2.3 2.26 -1.74
index_join_scan 1.89 1.89 0.0
index_scan 55.82 55.82 0.0
oltp_point_select 0.27 0.27 0.0
oltp_read_only 5.47 5.47 0.0
select_random_points 0.61 0.61 0.0
select_random_ranges 0.62 0.62 0.0
table_scan 56.84 56.84 0.0
types_table_scan 147.61 147.61 0.0
write_tests from_latency to_latency percent_change
oltp_delete_insert 5.88 5.88 0.0
oltp_insert 2.91 2.91 0.0
oltp_read_write 11.24 11.24 0.0
oltp_update_index 2.97 2.97 0.0
oltp_update_non_index 2.91 2.91 0.0
oltp_write_only 5.99 5.99 0.0
types_delete_insert 6.43 6.43 0.0

@max-hoffman
Copy link
Contributor Author

#benchmark

@github-actions GitHub Actions
Copy link

@max-hoffman workflow run: https://github.com/dolthub/dolt/actions/runs/11369956096

@coffeegoddd
Copy link
Contributor

@max-hoffman DOLT

comparing_percentages
100.000000 to 100.000000
version result total
a25076d ok 5937457
version total_tests
a25076d 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@max-hoffman DOLT

test_name from_latency_p95 to_latency_p95 percent_change
tpcc-scale-factor-1 65.65 63.32 -3.55
test_name from_server_name from_server_version from_tps to_server_name to_server_version to_tps percent_change
tpcc-scale-factor-1 dolt 73df10e 40.12 dolt a25076d 40.14 0.05

@coffeegoddd
Copy link
Contributor

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
c07b2d7 ok 5937457
version total_tests
c07b2d7 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@max-hoffman DOLT

read_tests from_latency to_latency percent_change
covering_index_scan 0.62 0.62 0.0
groupby_scan 16.71 16.71 0.0
index_join 2.3 2.26 -1.74
index_join_scan 1.86 1.89 1.61
index_scan 55.82 55.82 0.0
oltp_point_select 0.27 0.27 0.0
oltp_read_only 5.47 5.47 0.0
select_random_points 0.61 0.61 0.0
select_random_ranges 0.63 0.62 -1.59
table_scan 55.82 56.84 1.83
types_table_scan 144.97 144.97 0.0
write_tests from_latency to_latency percent_change
oltp_delete_insert 5.88 5.88 0.0
oltp_insert 2.91 2.91 0.0
oltp_read_write 11.24 11.24 0.0
oltp_update_index 2.97 2.97 0.0
oltp_update_non_index 2.91 2.91 0.0
oltp_write_only 5.99 5.99 0.0
types_delete_insert 6.43 6.43 0.0

@coffeegoddd
Copy link
Contributor

@max-hoffman DOLT

comparing_percentages
100.000000 to 100.000000
version result total
e97d407 ok 5937457
version total_tests
e97d407 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
133f228 ok 5937457
version total_tests
133f228 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@max-hoffman DOLT

comparing_percentages
100.000000 to 100.000000
version result total
d398a43 ok 5937457
version total_tests
d398a43 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@max-hoffman DOLT

comparing_percentages
100.000000 to 100.000000
version result total
9fb6704 ok 5937457
version total_tests
9fb6704 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@max-hoffman DOLT

comparing_percentages
100.000000 to 100.000000
version result total
dd4fda5 ok 5937457
version total_tests
dd4fda5 5937457
correctness_percentage
100.0

zachmu
zachmu approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

go/cmd/dolt/commands/sqlserver/server.go Outdated
@@ -271,8 +271,11 @@ func ConfigureServices(
var sqlEngine *engine.SqlEngine
InitSqlEngine := &svcs.AnonService{
InitF: func(ctx context.Context) (err error) {
if _, err := mrEnv.Config().GetString(env.SqlServerGlobalsPrefix + "." + dsess.DoltStatsBootstrapEnabled); err != nil {
// unless otherwise specified by config, enable server bootstrapping
if _, err := mrEnv.Config().GetString(env.SqlServerGlobalsPrefix + "." + dsess.DoltStatsAutoRefreshEnabled); err != nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logic is pretty weird. Variable is named "enabled" but we're treating it in the logic as "not disabled". Which is it? What is the default? Can it be set to "false"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, so just invert the naming now that we've inverted default behavior?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a second look, i think the confusing part is that we previously decided sql-server is the only context where we enable default stats behavior. So it is default off for everything but sql-server, and default on for sql-server unless the config explicitly specifies a behavior. I'm going to just document better and still ship the current behavior/naming.

@coffeegoddd
Copy link
Contributor

@max-hoffman DOLT

comparing_percentages
100.000000 to 100.000000
version result total
a6d5608 ok 5937457
version total_tests
a6d5608 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@max-hoffman DOLT

comparing_percentages
100.000000 to 100.000000
version result total
a020d8c ok 5937457
version total_tests
a020d8c 5937457
correctness_percentage
100.0

@max-hoffman max-hoffman merged commit 2d50424 into main Oct 24, 2024
21 checks passed
@max-hoffman max-hoffman deleted the max/default-stats branch October 24, 2024 01:38
@github-actions GitHub Actions
Copy link

@coffeegoddd DOLT

test_name detail row_cnt sorted mysql_time sql_mult cli_mult
batching LOAD DATA 10000 1 0.06 1.33
batching batch sql 10000 1 0.07 1.57
batching by line sql 10000 1 0.07 1.57
blob 1 blob 200000 1 0.9 3.61 3.44
blob 2 blobs 200000 1 0.89 4.15 4.27
blob no blob 200000 1 0.9 2.26 1.93
col type datetime 200000 1 0.83 2.83 2.72
col type varchar 200000 1 0.68 3.19 2.74
config width 2 cols 200000 1 0.76 2.45 1.96
config width 32 cols 200000 1 1.82 1.98 2.48
config width 8 cols 200000 1 0.97 2.23 1.93
pk type float 200000 1 0.85 2.28 1.82
pk type int 200000 1 0.84 2.21 1.8
pk type varchar 200000 1 1.57 1.81 1.29
row count 1.6mm 1600000 1 5.69 2.74 2.2
row count 400k 400000 1 1.44 2.65 2.12
row count 800k 800000 1 2.81 2.74 2.19
secondary index four index 200000 1 3.42 1.39 1.07
secondary index no secondary 200000 1 0.88 2.31 2
secondary index one index 200000 1 1.14 2.26 1.87
secondary index two index 200000 1 1.91 1.74 1.4
sorting shuffled 1mm 1000000 0 4.9 2.75 2.27
sorting sorted 1mm 1000000 1 4.98 2.71 2.29

@github-actions GitHub Actions
Copy link

@coffeegoddd DOLT

name detail mean_mult
dolt_blame_basic system table 1.12
dolt_blame_commit_filter system table 2.94
dolt_commit_ancestors_commit_filter system table 0.63
dolt_commits_commit_filter system table 1.05
dolt_diff_log_join_from_commit system table 2.15
dolt_diff_log_join_to_commit system table 2.15
dolt_diff_table_from_commit_filter system table 1.23
dolt_diff_table_to_commit_filter system table 1.21
dolt_diffs_commit_filter system table 1.03
dolt_history_commit_filter system table 1.41
dolt_log_commit_filter system table 1.05

@github-actions GitHub Actions
Copy link

@coffeegoddd DOLT

name add_cnt delete_cnt update_cnt latency
adds_only 60000 0 0 0.72
adds_updates_deletes 60000 60000 60000 3.77
deletes_only 0 60000 0 1.92
updates_only 0 0 60000 2.4

@BrewTestBot BrewTestBot mentioned this pull request Oct 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@max-hoffman @coffeegoddd @zachmu