Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More flexible diff printing when schema changes type of column #8359

Merged
merged 4 commits into from
Sep 16, 2024

Conversation

macneale4
Copy link
Contributor

This partially addresses an old bug described in the fixed issue. There are certainly more complete solutions, but this seems like the right amount of effort for something pretty edge casey.

Fixes: #8133

@coffeegoddd
Copy link
Contributor

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
b74d337 ok 5937457
version total_tests
b74d337 5937457
correctness_percentage
100.0

Copy link
Contributor

@jycor jycor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing case for DECIMAL(scale, prec)
Otherwise, LGTM!

go/cmd/dolt/commands/diff.go Outdated Show resolved Hide resolved
go/cmd/dolt/commands/diff.go Show resolved Hide resolved
@coffeegoddd
Copy link
Contributor

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
683c651 ok 5937457
version total_tests
683c651 5937457
correctness_percentage
100.0

@macneale4 macneale4 merged commit ecee0e0 into main Sep 16, 2024
21 checks passed
@macneale4 macneale4 deleted the macneale4/diff-schema-change branch September 16, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

\diff doesn't handle decimal diffs. It just prints integers.
3 participants