Liuliu/log-graph

[liuliu-dev]

command: dolt log --graph

Steps for Drawing the Commit Graph

1. Calculate the Positions of Each Commit:

• Row Position: Determined by the commit's topological order, initialized using the index in the list. Adjust the vertical spacing between commits based on the commit message's height in expandGraph function.

• Column Position, calculated based on the positions of child commits, implemented in computeColumnEnds function:

  • No Children: Places the commit in a new column (furthest right) if it has no child commits, indicating the start of a new branch.
  • Branch Children: If a commit has branch children, it is positioned in the same column as its leftmost branch child.
  • Merge Children: For commits with merge children, diagonal lines ('') are used to connect to these children, positioning the commit in an available column starting from its rightmost child.

2. Render the Graph:
   Place a * at each commit's calculated position to mark it.
   Connect commits using vertical (|) and diagonal (\ or /) lines to represent branches and merges.

An example of the graph of us-jails:

[coffeegoddd]

@liuliu-dev DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
af879e6	ok	5937457

version	total_tests
af879e6	5937457

correctness_percentage
100.0

[coffeegoddd]

@liuliu-dev DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
c23f150	ok	5937457

version	total_tests
c23f150	5937457

correctness_percentage
100.0

[coffeegoddd]

@liuliu-dev DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
16c683e	ok	5937457

version	total_tests
16c683e	5937457

correctness_percentage
100.0

[coffeegoddd]

@liuliu-dev DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
5695942	ok	5937457

version	total_tests
5695942	5937457

correctness_percentage
100.0

[timsehn]

A couple of output graphs in code blocks would be cool to see.

[timsehn]

Probably needs a couple bats tests.

[coffeegoddd]

@liuliu-dev DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
5ce04ab	ok	5937457

version	total_tests
5ce04ab	5937457

correctness_percentage
100.0

[coffeegoddd]

@liuliu-dev DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
c924c8c	ok	5937457

version	total_tests
c924c8c	5937457

correctness_percentage
100.0

[coffeegoddd]

@liuliu-dev DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
abacfb2	ok	5937457

version	total_tests
abacfb2	5937457

correctness_percentage
100.0

[macneale4]

I'm realizing now that I need a higher level description of the algorithm in order to properly review this. I want you to be overly heavy on documentation of fields and functions. Comments in functions are almost always a sign that the function is too complex, and should be broken into multiple functions. Not always, just a rule of thumb. I'm seeing some pretty long functions in this code, and the descriptions of what they each do doesn't come close to the amount of code in the function.

[coffeegoddd]

@liuliu-dev DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
a0a8dab	ok	5937457

version	total_tests
a0a8dab	5937457

correctness_percentage
100.0

[coffeegoddd]

@liuliu-dev DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
a5f41cc	ok	5937457

version	total_tests
a5f41cc	5937457

correctness_percentage
100.0

[macneale4]

Coming together! I think one more rev and you'll be good to go

[macneale4]

This type is only used in the package, so make it start with a lower case letter (makes it package private)

[coffeegoddd]

@liuliu-dev DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
e08f120	ok	5937457

version	total_tests
e08f120	5937457

correctness_percentage
100.0

[coffeegoddd]

@liuliu-dev DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
154d90c	ok	5937457

version	total_tests
154d90c	5937457

correctness_percentage
100.0

[coffeegoddd]

@liuliu-dev DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
2382bb3	ok	5937457

version	total_tests
2382bb3	5937457

correctness_percentage
100.0

[coffeegoddd]

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
eed2184	ok	5937457

version	total_tests
eed2184	5937457

correctness_percentage
100.0

[macneale4]

     .  o ..                  
     o . o o.o                
          ...oo               
            __[]__            
         __|_o_o_o\__         
         \""""""""""/         
          \. ..  . /          
     ^^^^^^^^^^^^^^^^^^^^