Skip to content

fix comparison for []byte#7584

Merged
jycor merged 4 commits intomainfrom
james/binary
Mar 8, 2024
Merged

fix comparison for []byte#7584
jycor merged 4 commits intomainfrom
james/binary

Conversation

@jycor
Copy link
Contributor

@jycor jycor commented Mar 7, 2024

convert []bytes to string before comparing them

companion pr (with tests):
dolthub/go-mysql-server#2377

fixes #7578

@coffeegoddd
Copy link
Contributor

@jycor DOLT

comparing_percentages
100.000000 to 100.000000
version result total
64e113c ok 5937457
version total_tests
64e113c 5937457
correctness_percentage
100.0

Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@coffeegoddd
Copy link
Contributor

@jycor DOLT

comparing_percentages
100.000000 to 100.000000
version result total
a3a0b83 ok 5937457
version total_tests
a3a0b83 5937457
correctness_percentage
100.0

@jycor jycor merged commit df23415 into main Mar 8, 2024
@tbantle22 tbantle22 deleted the james/binary branch November 21, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Panic on comparison in Query generated by MediaWiki.

3 participants