Skip to content

fix bad charset tests and dolt table import schema#7581

Merged
jycor merged 4 commits intomainfrom
james/charset
Mar 7, 2024
Merged

fix bad charset tests and dolt table import schema#7581
jycor merged 4 commits intomainfrom
james/charset

Conversation

@jycor
Copy link
Contributor

@jycor jycor commented Mar 7, 2024

recent charset changes exposed some issues with existing tests

companion: dolthub/go-mysql-server#2376

Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@coffeegoddd
Copy link
Contributor

@jycor DOLT

comparing_percentages
100.000000 to 100.000000
version result total
d03edd4 ok 5937457
version total_tests
d03edd4 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@jycor DOLT

comparing_percentages
100.000000 to 100.000000
version result total
91294b7 ok 5937457
version total_tests
91294b7 5937457
correctness_percentage
100.0

@jycor jycor merged commit 2b6a11d into main Mar 7, 2024
@jycor jycor deleted the james/charset branch March 7, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants