Skip to content

Update validation for dropping an auto_increment primary key column#7462

Merged
fulghum merged 11 commits intomainfrom
fulghum/dolt-7456
Feb 7, 2024
Merged

Update validation for dropping an auto_increment primary key column#7462
fulghum merged 11 commits intomainfrom
fulghum/dolt-7456

Conversation

@fulghum
Copy link
Copy Markdown
Contributor

@fulghum fulghum commented Feb 6, 2024

Allows auto_increment primary key columns to be dropped, so long as there exists a secondary index that covers the auto_increment column.

Depends on dolthub/go-mysql-server#2316

Related to #7456

@coffeegoddd
Copy link
Copy Markdown
Contributor

@fulghum DOLT

comparing_percentages
99.999562 to 99.999124
version result total
fd4b048 not ok 52
fd4b048 ok 5937405
version total_tests
fd4b048 5937457
correctness_percentage
99.999124

@coffeegoddd
Copy link
Copy Markdown
Contributor

@fulghum DOLT

comparing_percentages
99.999562 to 99.999124
version result total
0f95427 not ok 52
0f95427 ok 5937405
version total_tests
0f95427 5937457
correctness_percentage
99.999124

@fulghum fulghum requested a review from zachmu February 6, 2024 21:00
@coffeegoddd
Copy link
Copy Markdown
Contributor

@fulghum DOLT

comparing_percentages
99.999562 to 99.999562
version result total
6517e97 not ok 26
6517e97 ok 5937431
version total_tests
6517e97 5937457
correctness_percentage
99.999562

Copy link
Copy Markdown
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@coffeegoddd
Copy link
Copy Markdown
Contributor

@fulghum DOLT

comparing_percentages
99.999562 to 99.999562
version result total
41604c3 not ok 26
41604c3 ok 5937431
version total_tests
41604c3 5937457
correctness_percentage
99.999562

@fulghum fulghum merged commit 0428499 into main Feb 7, 2024
@fulghum fulghum deleted the fulghum/dolt-7456 branch February 7, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants