Skip to content

Added storage capabilities for GMS Extended Types#7457

Merged
Hydrocharged merged 2 commits intomainfrom
daylon/super-type
Feb 7, 2024
Merged

Added storage capabilities for GMS Extended Types#7457
Hydrocharged merged 2 commits intomainfrom
daylon/super-type

Conversation

@Hydrocharged
Copy link
Contributor

@Hydrocharged Hydrocharged commented Feb 5, 2024 •
edited
Loading

This adds the necessary scaffolding to support the new ExtendedType interface within GMS. This interface is primarily used by DoltgreSQL to implement PostgreSQL types.

Related PRs:

This was referenced Feb 5, 2024
Merged
Merged
@coffeegoddd
Copy link
Contributor

coffeegoddd commented Feb 5, 2024

@Hydrocharged DOLT

comparing_percentages
99.999124 to 99.999124
version result total
fc7c342 not ok 52
fc7c342 ok 5937405
version total_tests
fc7c342 5937457
correctness_percentage
99.999124

@coffeegoddd
Copy link
Contributor

coffeegoddd commented Feb 5, 2024

@Hydrocharged DOLT

comparing_percentages
99.999124 to 99.999124
version result total
bf0fa92 not ok 52
bf0fa92 ok 5937405
version total_tests
bf0fa92 5937457
correctness_percentage
99.999124

zachmu
zachmu approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coffeegoddd
Copy link
Contributor

coffeegoddd commented Feb 7, 2024

@Hydrocharged DOLT

comparing_percentages
99.999562 to 99.999562
version result total
36efa2c not ok 26
36efa2c ok 5937431
version total_tests
36efa2c 5937457
correctness_percentage
99.999562

@coffeegoddd
Copy link
Contributor

coffeegoddd commented Feb 7, 2024

@coffeegoddd DOLT

comparing_percentages
99.999562 to 99.999562
version result total
0e4fe05 not ok 26
0e4fe05 ok 5937431
version total_tests
0e4fe05 5937457
correctness_percentage
99.999562

@Hydrocharged Hydrocharged merged commit cbe6b0c into main Feb 7, 2024
@Hydrocharged Hydrocharged deleted the daylon/super-type branch February 7, 2024 14:23
@BrewTestBot BrewTestBot mentioned this pull request Feb 10, 2024
Merged
@Porkepix Porkepix mentioned this pull request Feb 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zachmu zachmu zachmu approved these changes

+1 more reviewer

@max-hoffman max-hoffman max-hoffman left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

correctness_approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Hydrocharged @coffeegoddd @zachmu @max-hoffman