Skip to content

dolt_clone and --user#7432

Merged
macneale4 merged 5 commits intomainfrom
macneale4/clone-proc-auth
Jan 31, 2024
Merged

dolt_clone and --user#7432
macneale4 merged 5 commits intomainfrom
macneale4/clone-proc-auth

Conversation

@macneale4
Copy link
Contributor

Previously the dolt_clone() stored procedure would take the --user flag, but not use it in a gRPC call to a sql-server. This
addresses this limitation, and adds a test to verify it works.

@macneale4 macneale4 requested a review from reltuk January 30, 2024 22:37
@coffeegoddd
Copy link
Contributor

@macneale4 DOLT

comparing_percentages
99.998787 to 99.998787
version result total
1634556 not ok 72
1634556 ok 5937385
version total_tests
1634556 5937457
correctness_percentage
99.998787

@coffeegoddd
Copy link
Contributor

@coffeegoddd DOLT

comparing_percentages
99.998787 to 99.998787
version result total
9aae715 not ok 72
9aae715 ok 5937385
version total_tests
9aae715 5937457
correctness_percentage
99.998787

Copy link
Contributor

@reltuk reltuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@coffeegoddd
Copy link
Contributor

@macneale4 DOLT

comparing_percentages
99.998787 to 99.998787
version result total
52a32ff not ok 72
52a32ff ok 5937385
version total_tests
52a32ff 5937457
correctness_percentage
99.998787

@macneale4 macneale4 merged commit 47bc23c into main Jan 31, 2024
@macneale4 macneale4 deleted the macneale4/clone-proc-auth branch January 31, 2024 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants