You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
I still need to dig through the tests and play with a local build a little bit, but wanted to send out a first batch of feedback in case you want to get started on any of these while I continue reviewing.
The reason will be displayed to describe this comment to others. Learn more.
I finished going through the tests and played with a local build a little bit. Things are looking good! Just a couple more small comments. Hit me up after you get a chance to go through the feedback and I'm happy to take one more quick look before we ship this one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
dolt rebasecommand which is supported by thedolt_rebase()procedure.Related: https://github.com/dolthub/ld/pull/16323