Skip to content

add dolt rebase command#7373

Merged
stephkyou merged 11 commits intomainfrom
steph/rebase
Jan 23, 2024
Merged

add dolt rebase command#7373
stephkyou merged 11 commits intomainfrom
steph/rebase

Conversation

@stephkyou
Copy link
Contributor

@stephkyou stephkyou commented Jan 19, 2024

Adds the dolt rebase command which is supported by the dolt_rebase() procedure.

Related: https://github.com/dolthub/ld/pull/16323

@coffeegoddd
Copy link
Contributor

@coffeegoddd DOLT

comparing_percentages
99.997743 to 99.997743
version result total
c784959 not ok 134
c784959 ok 5937323
version total_tests
c784959 5937457
correctness_percentage
99.997743

@coffeegoddd
Copy link
Contributor

@stephkyou DOLT

comparing_percentages
99.997743 to 99.997743
version result total
a8f58bd not ok 134
a8f58bd ok 5937323
version total_tests
a8f58bd 5937457
correctness_percentage
99.997743

@stephkyou stephkyou marked this pull request as ready for review January 19, 2024 17:27
@stephkyou stephkyou requested a review from fulghum January 19, 2024 17:28
Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still need to dig through the tests and play with a local build a little bit, but wanted to send out a first batch of feedback in case you want to get started on any of these while I continue reviewing.

Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more quick comments... I'll hop back on this and finish up when I get back into the office in a bit.

Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I finished going through the tests and played with a local build a little bit. Things are looking good! Just a couple more small comments. Hit me up after you get a chance to go through the feedback and I'm happy to take one more quick look before we ship this one.

@coffeegoddd
Copy link
Contributor

@stephkyou DOLT

comparing_percentages
99.998097 to 99.997743
version result total
b3d5705 not ok 134
b3d5705 ok 5937323
version total_tests
b3d5705 5937457
correctness_percentage
99.997743

Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on this one! Looks great! 🚢

@coffeegoddd
Copy link
Contributor

@stephkyou DOLT

comparing_percentages
99.998097 to 99.998097
version result total
89c8e80 not ok 113
89c8e80 ok 5937344
version total_tests
89c8e80 5937457
correctness_percentage
99.998097

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants