Skip to content

Special handling of comment delimiters in StreamScanner#10702

Merged
angelamayxie merged 2 commits intomainfrom
angela/commentquote
Mar 18, 2026
Merged

Special handling of comment delimiters in StreamScanner#10702
angelamayxie merged 2 commits intomainfrom
angela/commentquote

Conversation

@angelamayxie
Copy link
Copy Markdown
Contributor

fixes #10694

@coffeegoddd
Copy link
Copy Markdown
Contributor

coffeegoddd commented Mar 17, 2026

@angelamayxie DOLT

read_tests from_latency to_latency percent_change
covering_index_scan 0.57 0.55 -3.51
groupby_scan 10.09 9.91 -1.78
index_join 1.86 1.82 -2.15
index_join_scan 1.39 1.39 0.0
index_scan 21.89 21.89 0.0
oltp_point_select 0.27 0.27 0.0
oltp_read_only 5.28 5.28 0.0
select_random_points 0.53 0.53 0.0
select_random_ranges 0.56 0.56 0.0
table_scan 21.89 21.89 0.0
types_table_scan 65.65 66.84 1.81
write_tests from_latency to_latency percent_change
oltp_delete_insert 6.32 6.32 0.0
oltp_insert 3.13 3.13 0.0
oltp_read_write 11.24 11.45 1.87
oltp_update_index 3.19 3.19 0.0
oltp_update_non_index 3.13 3.13 0.0
oltp_write_only 5.99 5.99 0.0
types_delete_insert 6.79 6.79 0.0

@coffeegoddd
Copy link
Copy Markdown
Contributor

@angelamayxie DOLT

comparing_percentages
100.000000 to 100.000000
version result total
94230ee ok 5937471
version total_tests
94230ee 5937471
correctness_percentage
100.0

@coffeegoddd
Copy link
Copy Markdown
Contributor

coffeegoddd commented Mar 18, 2026

@angelamayxie DOLT

test_name from_latency_p95 to_latency_p95 percent_change
tpcc-scale-factor-1 61.08 61.08 0.0
test_name from_server_name from_server_version from_tps to_server_name to_server_version to_tps percent_change
tpcc-scale-factor-1 dolt 0294acf 37.81 dolt 94230ee 38.04 0.61

@angelamayxie angelamayxie marked this pull request as ready for review March 18, 2026 00:03
Copy link
Copy Markdown
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@angelamayxie angelamayxie merged commit 4dfa533 into main Mar 18, 2026
27 of 30 checks passed
@angelamayxie angelamayxie deleted the angela/commentquote branch March 18, 2026 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parse error when two lines follow a comment containing singlequote

3 participants