Fix nil pointer panic in workspace table Update and Delete methods#10590
Merged
jycor merged 1 commit intodolthub:mainfrom Mar 2, 2026
Merged
Fix nil pointer panic in workspace table Update and Delete methods#10590jycor merged 1 commit intodolthub:mainfrom
jycor merged 1 commit intodolthub:mainfrom
Conversation
When StatementBegin encounters an error (e.g., table not found in staging root), it stores the error in wtu.err but leaves tableWriter as nil. The Update and Delete methods were dereferencing tableWriter before checking if it was nil, causing a panic. This fix adds an early return to check for errors from StatementBegin before attempting to use tableWriter, preventing the nil pointer dereference.
Contributor
|
@nullun Thank for your the contribution. |
Contributor
Author
|
@coffeegoddd DOLT
|
|
@coffeegoddd DOLT
|
DreadPirateRobertz
added a commit
to DreadPirateRobertz/gastown
that referenced
this pull request
Mar 7, 2026
Dolt v1.83.1 includes dolthub/dolt#10590 which fixes nil pointer panics in workspace table Update/Delete methods when StatementBegin encounters errors. Updates MinDoltVersion constant, Dockerfile, and all docs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
3 tasks
DreadPirateRobertz
added a commit
to DreadPirateRobertz/gastown
that referenced
this pull request
Mar 8, 2026
Dolt v1.83.1 includes dolthub/dolt#10590 which fixes nil pointer panics in workspace table Update/Delete methods when StatementBegin encounters errors. Updates MinDoltVersion constant, Dockerfile, and all docs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
DreadPirateRobertz
added a commit
to DreadPirateRobertz/gastown
that referenced
this pull request
Mar 8, 2026
Dolt v1.83.1 includes dolthub/dolt#10590 which fixes nil pointer panics in workspace table Update/Delete methods when StatementBegin encounters errors. Updates MinDoltVersion constant, Dockerfile, and all docs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When StatementBegin encounters an error (e.g., table not found in staging root), it stores the error in wtu.err but leaves tableWriter as nil. The Update and Delete methods were dereferencing tableWriter before checking if it was nil, causing a panic.
This fix adds an early return to check for errors from StatementBegin before attempting to use tableWriter, preventing the nil pointer dereference.