/{docker,go,integration-tests}: install git in docker containers, fix .git suffix on clone in sql-server#10496
Merged
coffeegoddd merged 2 commits intomainfrom Feb 12, 2026
Merged
/{docker,go,integration-tests}: install git in docker containers, fix .git suffix on clone in sql-server#10496coffeegoddd merged 2 commits intomainfrom
coffeegoddd merged 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aligns the SQL stored procedure dolt_clone behavior with the CLI dolt clone behavior for git remotes ending in .git, and ensures required git tooling is available in container images used for server / integration testing.
Changes:
- Add
.gitsuffix stripping whendolt_cloneinfers a database name from a remote URL. - Add an integration test verifying
.gitis stripped for git remotes cloned via SQL server stored procedure. - Install
gitin Docker images so git remotes can be cloned in containerized environments.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| integration-tests/bats/sql-server.bats | Adds a BATS test asserting .git suffix is stripped when cloning a git remote via call dolt_clone(...). |
| go/libraries/doltcore/sqle/dprocedures/dolt_clone.go | Updates inferred directory logic to trim trailing .git, matching CLI clone behavior. |
| docker/serverDockerfile | Installs git in the base layer used by runtime images. |
| docker/Dockerfile | Installs git in the Ubuntu-based dolt image. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
@coffeegoddd DOLT
|
Contributor
Author
|
@coffeegoddd DOLT
|
Contributor
Author
|
@coffeegoddd DOLT
|
Contributor
Author
|
@coffeegoddd DOLT
|
Contributor
Author
|
@coffeegoddd DOLT
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.