Skip to content

/{docker,go,integration-tests}: install git in docker containers, fix .git suffix on clone in sql-server#10496

Merged
coffeegoddd merged 2 commits intomainfrom
db/fixes
Feb 12, 2026
Merged

/{docker,go,integration-tests}: install git in docker containers, fix .git suffix on clone in sql-server#10496
coffeegoddd merged 2 commits intomainfrom
db/fixes

Conversation

@coffeegoddd
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aligns the SQL stored procedure dolt_clone behavior with the CLI dolt clone behavior for git remotes ending in .git, and ensures required git tooling is available in container images used for server / integration testing.

Changes:

  • Add .git suffix stripping when dolt_clone infers a database name from a remote URL.
  • Add an integration test verifying .git is stripped for git remotes cloned via SQL server stored procedure.
  • Install git in Docker images so git remotes can be cloned in containerized environments.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
integration-tests/bats/sql-server.bats Adds a BATS test asserting .git suffix is stripped when cloning a git remote via call dolt_clone(...).
go/libraries/doltcore/sqle/dprocedures/dolt_clone.go Updates inferred directory logic to trim trailing .git, matching CLI clone behavior.
docker/serverDockerfile Installs git in the base layer used by runtime images.
docker/Dockerfile Installs git in the Ubuntu-based dolt image.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@coffeegoddd
Copy link
Copy Markdown
Contributor Author

@coffeegoddd DOLT

read_tests from_latency to_latency percent_change
covering_index_scan 0.54 0.57 5.56
groupby_scan 9.91 9.91 0.0
index_join 1.86 1.82 -2.15
index_join_scan 1.34 1.34 0.0
index_scan 21.89 21.89 0.0
oltp_point_select 0.28 0.28 0.0
oltp_read_only 5.28 5.37 1.7
select_random_points 0.54 0.54 0.0
select_random_ranges 0.56 0.56 0.0
table_scan 22.28 22.28 0.0
types_table_scan 66.84 66.84 0.0
write_tests from_latency to_latency percent_change
oltp_delete_insert 6.32 6.32 0.0
oltp_insert 3.07 3.07 0.0
oltp_read_write 11.45 11.45 0.0
oltp_update_index 3.19 3.25 1.88
oltp_update_non_index 3.13 3.13 0.0
oltp_write_only 6.09 6.09 0.0
types_delete_insert 6.79 6.91 1.77

@coffeegoddd
Copy link
Copy Markdown
Contributor Author

@coffeegoddd DOLT

test_name from_latency_p95 to_latency_p95 percent_change
tpcc-scale-factor-1 61.08 61.08 0.0
test_name from_server_name from_server_version from_tps to_server_name to_server_version to_tps percent_change
tpcc-scale-factor-1 dolt d30063b 37.56 dolt 7fe6eb7 37.64 0.21

@coffeegoddd
Copy link
Copy Markdown
Contributor Author

@coffeegoddd DOLT

read_tests from_latency to_latency percent_change
covering_index_scan 0.55 0.57 3.64
groupby_scan 9.91 10.09 1.82
index_join 1.82 1.82 0.0
index_join_scan 1.34 1.34 0.0
index_scan 21.89 21.89 0.0
oltp_point_select 0.27 0.28 3.7
oltp_read_only 5.28 5.37 1.7
select_random_points 0.54 0.54 0.0
select_random_ranges 0.55 0.56 1.82
table_scan 22.69 22.28 -1.81
types_table_scan 66.84 66.84 0.0
write_tests from_latency to_latency percent_change
oltp_delete_insert 6.32 6.32 0.0
oltp_insert 3.07 3.07 0.0
oltp_read_write 11.45 11.45 0.0
oltp_update_index 3.19 3.19 0.0
oltp_update_non_index 3.13 3.13 0.0
oltp_write_only 6.09 6.09 0.0
types_delete_insert 6.79 6.91 1.77

@coffeegoddd
Copy link
Copy Markdown
Contributor Author

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
7238cc5 ok 5937471
version total_tests
7238cc5 5937471
correctness_percentage
100.0

@coffeegoddd coffeegoddd changed the title /{docker,go,integration-tests}: install git, remote .git suffix on server dolt clone /{docker,go,integration-tests}: install git in docker containers, fix .git suffix on clone in sql-server Feb 12, 2026
@coffeegoddd
Copy link
Copy Markdown
Contributor Author

@coffeegoddd DOLT

test_name from_latency_p95 to_latency_p95 percent_change
tpcc-scale-factor-1 61.08 62.19 1.82
test_name from_server_name from_server_version from_tps to_server_name to_server_version to_tps percent_change
tpcc-scale-factor-1 dolt d30063b 37.49 dolt 7238cc5 37.34 -0.4

@coffeegoddd coffeegoddd merged commit 7987a42 into main Feb 12, 2026
26 of 35 checks passed
@coffeegoddd coffeegoddd deleted the db/fixes branch February 12, 2026 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants