Skip to content

Fix dolt_clean not respecting dolt_ignore and dolt_nonlocal_tables patterns#10487

Merged
elianddb merged 6 commits intomainfrom
elian/10462
Feb 12, 2026
Merged

Fix dolt_clean not respecting dolt_ignore and dolt_nonlocal_tables patterns#10487
elianddb merged 6 commits intomainfrom
elian/10462

Conversation

@elianddb
Copy link
Copy Markdown
Contributor

@elianddb elianddb commented Feb 12, 2026

Fix #10462

  • Fix dolt_ignore and dolt_nonlocal_tables not being excluded from dolt clean default command and SQL interface.
  • Add dolt clean -x flag to override dolt_ignore deletions; similar to git clean -x.

@coffeegoddd
Copy link
Copy Markdown
Contributor

@elianddb DOLT

read_tests from_latency to_latency percent_change
covering_index_scan 0.56 0.55 -1.79
groupby_scan 9.91 9.91 0.0
index_join 1.82 1.86 2.2
index_join_scan 1.34 1.34 0.0
index_scan 22.28 21.89 -1.75
oltp_point_select 0.27 0.27 0.0
oltp_read_only 5.37 5.28 -1.68
select_random_points 0.54 0.54 0.0
select_random_ranges 0.55 0.57 3.64
table_scan 22.28 22.28 0.0
types_table_scan 66.84 65.65 -1.78
write_tests from_latency to_latency percent_change
oltp_delete_insert 6.32 6.32 0.0
oltp_insert 3.07 3.07 0.0
oltp_read_write 11.45 11.45 0.0
oltp_update_index 3.19 3.19 0.0
oltp_update_non_index 3.13 3.13 0.0
oltp_write_only 6.09 6.09 0.0
types_delete_insert 6.91 6.79 -1.74

@coffeegoddd
Copy link
Copy Markdown
Contributor

@elianddb DOLT

read_tests from_latency to_latency percent_change
covering_index_scan 0.56 0.55 -1.79
groupby_scan 9.91 9.91 0.0
index_join 1.82 1.82 0.0
index_join_scan 1.34 1.34 0.0
index_scan 21.89 21.89 0.0
oltp_point_select 0.27 0.27 0.0
oltp_read_only 5.28 5.28 0.0
select_random_points 0.54 0.54 0.0
select_random_ranges 0.55 0.56 1.82
table_scan 21.89 22.28 1.78
types_table_scan 66.84 65.65 -1.78
write_tests from_latency to_latency percent_change
oltp_delete_insert 6.32 6.32 0.0
oltp_insert 3.02 3.07 1.66
oltp_read_write 11.45 11.45 0.0
oltp_update_index 3.25 3.19 -1.85
oltp_update_non_index 3.13 3.13 0.0
oltp_write_only 6.09 6.09 0.0
types_delete_insert 6.79 6.79 0.0

@coffeegoddd
Copy link
Copy Markdown
Contributor

@elianddb DOLT

read_tests from_latency to_latency percent_change
covering_index_scan 0.56 0.54 -3.57
groupby_scan 9.91 9.91 0.0
index_join 1.86 1.82 -2.15
index_join_scan 1.34 1.34 0.0
index_scan 21.89 22.28 1.78
oltp_point_select 0.27 0.27 0.0
oltp_read_only 5.37 5.37 0.0
select_random_points 0.54 0.54 0.0
select_random_ranges 0.55 0.56 1.82
table_scan 21.89 22.28 1.78
types_table_scan 65.65 66.84 1.81
write_tests from_latency to_latency percent_change
oltp_delete_insert 6.32 6.32 0.0
oltp_insert 3.07 3.07 0.0
oltp_read_write 11.45 11.45 0.0
oltp_update_index 3.19 3.19 0.0
oltp_update_non_index 3.13 3.13 0.0
oltp_write_only 6.09 6.09 0.0
types_delete_insert 6.91 6.79 -1.74

@coffeegoddd
Copy link
Copy Markdown
Contributor

@elianddb DOLT

test_name from_latency_p95 to_latency_p95 percent_change
tpcc-scale-factor-1 61.08 62.19 1.82
test_name from_server_name from_server_version from_tps to_server_name to_server_version to_tps percent_change
tpcc-scale-factor-1 dolt 069285c 37.47 dolt 1c4d96e 36.99 -1.28

@coffeegoddd
Copy link
Copy Markdown
Contributor

@elianddb DOLT

comparing_percentages
100.000000 to 100.000000
version result total
4748ed5 ok 5937471
version total_tests
4748ed5 5937471
correctness_percentage
100.0

@coffeegoddd
Copy link
Copy Markdown
Contributor

@elianddb DOLT

test_name from_latency_p95 to_latency_p95 percent_change
tpcc-scale-factor-1 61.08 62.19 1.82
test_name from_server_name from_server_version from_tps to_server_name to_server_version to_tps percent_change
tpcc-scale-factor-1 dolt 069285c 37.96 dolt 73ec420 37.67 -0.76

@coffeegoddd
Copy link
Copy Markdown
Contributor

@elianddb DOLT

test_name from_latency_p95 to_latency_p95 percent_change
tpcc-scale-factor-1 61.08 61.08 0.0
test_name from_server_name from_server_version from_tps to_server_name to_server_version to_tps percent_change
tpcc-scale-factor-1 dolt 069285c 38.03 dolt 4748ed5 38.25 0.58

@elianddb elianddb force-pushed the elian/10462 branch 2 times, most recently from ab9a225 to e23ae11 Compare February 12, 2026 01:09
@coffeegoddd
Copy link
Copy Markdown
Contributor

@elianddb DOLT

read_tests from_latency to_latency percent_change
covering_index_scan 0.57 0.58 1.75
groupby_scan 9.73 9.91 1.85
index_join 1.82 1.82 0.0
index_join_scan 1.34 1.34 0.0
index_scan 21.89 21.89 0.0
oltp_point_select 0.28 0.27 -3.57
oltp_read_only 5.28 5.37 1.7
select_random_points 0.54 0.53 -1.85
select_random_ranges 0.55 0.56 1.82
table_scan 22.28 21.89 -1.75
types_table_scan 66.84 66.84 0.0
write_tests from_latency to_latency percent_change
oltp_delete_insert 6.32 6.32 0.0
oltp_insert 3.07 3.07 0.0
oltp_read_write 11.45 11.45 0.0
oltp_update_index 3.19 3.19 0.0
oltp_update_non_index 3.13 3.13 0.0
oltp_write_only 6.09 6.09 0.0
types_delete_insert 6.79 6.79 0.0

@coffeegoddd
Copy link
Copy Markdown
Contributor

@elianddb DOLT

comparing_percentages
100.000000 to 100.000000
version result total
e23ae11 ok 5937471
version total_tests
e23ae11 5937471
correctness_percentage
100.0

@coffeegoddd
Copy link
Copy Markdown
Contributor

@elianddb DOLT

test_name from_latency_p95 to_latency_p95 percent_change
tpcc-scale-factor-1 62.19 61.08 -1.78
test_name from_server_name from_server_version from_tps to_server_name to_server_version to_tps percent_change
tpcc-scale-factor-1 dolt 621a810 37.71 dolt e23ae11 37.67 -0.11

@coffeegoddd
Copy link
Copy Markdown
Contributor

@elianddb DOLT

read_tests from_latency to_latency percent_change
covering_index_scan 0.57 0.57 0.0
groupby_scan 10.65 10.84 1.78
index_join 1.89 1.89 0.0
index_join_scan 1.34 1.34 0.0
index_scan 21.89 21.89 0.0
oltp_point_select 0.27 0.28 3.7
oltp_read_only 5.28 5.28 0.0
select_random_points 0.54 0.54 0.0
select_random_ranges 0.55 0.55 0.0
table_scan 21.89 22.28 1.78
types_table_scan 66.84 66.84 0.0
write_tests from_latency to_latency percent_change
oltp_delete_insert 6.32 6.32 0.0
oltp_insert 3.07 3.07 0.0
oltp_read_write 11.45 11.45 0.0
oltp_update_index 3.19 3.19 0.0
oltp_update_non_index 3.13 3.13 0.0
oltp_write_only 6.09 6.09 0.0
types_delete_insert 6.79 6.79 0.0

@coffeegoddd
Copy link
Copy Markdown
Contributor

@elianddb DOLT

comparing_percentages
100.000000 to 100.000000
version result total
0175a2d ok 5937471
version total_tests
0175a2d 5937471
correctness_percentage
100.0

@coffeegoddd
Copy link
Copy Markdown
Contributor

@elianddb DOLT

test_name from_latency_p95 to_latency_p95 percent_change
tpcc-scale-factor-1 61.08 61.08 0.0
test_name from_server_name from_server_version from_tps to_server_name to_server_version to_tps percent_change
tpcc-scale-factor-1 dolt 7e12297 37.98 dolt 0175a2d 37.3 -1.79

@coffeegoddd
Copy link
Copy Markdown
Contributor

@elianddb DOLT

read_tests from_latency to_latency percent_change
covering_index_scan 0.57 0.57 0.0
groupby_scan 9.73 9.91 1.85
index_join 1.82 1.82 0.0
index_join_scan 1.32 1.34 1.52
index_scan 21.89 21.89 0.0
oltp_point_select 0.27 0.28 3.7
oltp_read_only 5.28 5.28 0.0
select_random_points 0.53 0.54 1.89
select_random_ranges 0.55 0.55 0.0
table_scan 22.28 21.89 -1.75
types_table_scan 66.84 66.84 0.0
write_tests from_latency to_latency percent_change
oltp_delete_insert 6.32 6.32 0.0
oltp_insert 3.07 3.07 0.0
oltp_read_write 11.45 11.45 0.0
oltp_update_index 3.19 3.19 0.0
oltp_update_non_index 3.13 3.13 0.0
oltp_write_only 6.09 6.09 0.0
types_delete_insert 6.79 6.79 0.0

@coffeegoddd
Copy link
Copy Markdown
Contributor

@elianddb DOLT

comparing_percentages
100.000000 to 100.000000
version result total
da41e3e ok 5937471
version total_tests
da41e3e 5937471
correctness_percentage
100.0

@coffeegoddd
Copy link
Copy Markdown
Contributor

@elianddb DOLT

test_name from_latency_p95 to_latency_p95 percent_change
tpcc-scale-factor-1 61.08 61.08 0.0
test_name from_server_name from_server_version from_tps to_server_name to_server_version to_tps percent_change
tpcc-scale-factor-1 dolt 7e12297 38.13 dolt da41e3e 37.63 -1.31

Copy link
Copy Markdown
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one small request for the nonlocal table test.

@coffeegoddd
Copy link
Copy Markdown
Contributor

@elianddb DOLT

read_tests from_latency to_latency percent_change
covering_index_scan 0.57 0.56 -1.75
groupby_scan 9.91 9.91 0.0
index_join 1.82 1.82 0.0
index_join_scan 1.34 1.34 0.0
index_scan 21.89 21.89 0.0
oltp_point_select 0.27 0.28 3.7
oltp_read_only 5.37 5.28 -1.68
select_random_points 0.53 0.54 1.89
select_random_ranges 0.56 0.57 1.79
table_scan 21.89 21.89 0.0
types_table_scan 65.65 65.65 0.0
write_tests from_latency to_latency percent_change
oltp_delete_insert 6.32 6.32 0.0
oltp_insert 3.07 3.07 0.0
oltp_read_write 11.45 11.45 0.0
oltp_update_index 3.19 3.19 0.0
oltp_update_non_index 3.13 3.13 0.0
oltp_write_only 6.09 6.09 0.0
types_delete_insert 6.91 6.79 -1.74

@coffeegoddd
Copy link
Copy Markdown
Contributor

@elianddb DOLT

comparing_percentages
100.000000 to 100.000000
version result total
f0e4dfd ok 5937471
version total_tests
f0e4dfd 5937471
correctness_percentage
100.0

@coffeegoddd
Copy link
Copy Markdown
Contributor

@elianddb DOLT

test_name from_latency_p95 to_latency_p95 percent_change
tpcc-scale-factor-1 61.08 61.08 0.0
test_name from_server_name from_server_version from_tps to_server_name to_server_version to_tps percent_change
tpcc-scale-factor-1 dolt 7c58d97 37.94 dolt f0e4dfd 37.75 -0.5

@elianddb elianddb merged commit 37e1b60 into main Feb 12, 2026
27 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dolt_clear() drops Nonlocal Tables

4 participants