commit verification with dolt_tests#10482
Merged
Conversation
Contributor
|
@macneale4 DOLT
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Also remove some nonsense claude stuff
macneale4
force-pushed
the
macneale4-claude/commit-hooks2
branch
from
59413b6 to
8272ad1
Compare
macneale4
changed the title
Contributor
|
@macneale4 DOLT
|
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
|
@coffeegoddd DOLT
|
Contributor
|
@macneale4 DOLT
|
Contributor
|
@macneale4 DOLT
|
Contributor
|
@macneale4 DOLT
|
Contributor
|
@coffeegoddd DOLT
|
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
|
@macneale4 DOLT
|
Contributor
|
@macneale4 DOLT
|
fulghum
approved these changes
Feb 12, 2026
Comment on lines
+184
to
+185
| // runTestsUsingDtablefunctions runs tests using the dtablefunctions package against the staged root | ||
| func runTestsUsingDtablefunctions(ctx *sql.Context, engine *gms.Engine, testGroups []string) error { |
Contributor
There was a problem hiding this comment.
(minor) This name confused me for a minute... something like "runTestsUsingDoltTestRun" might be more self describing, instead of including the Go package where the table function is stored.
Comment on lines
+33
to
+41
| func (chv *commitHashValidator) Validate(val interface{}) (bool, error) { | ||
| h, ok := val.(string) | ||
| if !ok { | ||
| return false, nil | ||
| } | ||
|
|
||
| _, ok = hash.MaybeParse(h) | ||
| return ok, nil | ||
| } |
Contributor
There was a problem hiding this comment.
(minor) There's an existing doltCommitValidator in the enginetest package that you could reuse if you wanted to. Not a big deal, but would let you delete a few lines of code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to perform verification of commit content using the dolt_tests table.
Setting the
dolt_commit_verification_groupsystem variable with a comma delimited set of test groups will result in test being run before a commit is completed.This validation is performed for commit, merge, cherry-pick, and rebase (through cherry-pick). All procedures/CLI operations provide the --skip-verification flag to bypass.
Currently one known bug with a skipped test. Rebase workflow is presenting broken when a commit fails verification, but should be handled like a conflict, which would allow the user to --continue the workflow.