[no-review-notes] Removed most of the remaining LD_1 specific codepaths and types

[zachmu]

No description provided.

[coffeegoddd]

@zachmu DOLT

read_tests	from_latency	to_latency	percent_change
covering_index_scan	0.55	0.55	0.0
groupby_scan	10.09	9.91	-1.78
index_join	1.82	1.82	0.0
index_join_scan	1.34	1.34	0.0
index_scan	22.28	21.89	-1.75
oltp_point_select	0.27	0.28	3.7
oltp_read_only	5.28	5.28	0.0
select_random_points	0.54	0.53	-1.85
select_random_ranges	0.55	0.56	1.82
table_scan	22.28	22.28	0.0
types_table_scan	66.84	66.84	0.0

write_tests	from_latency	to_latency	percent_change
oltp_delete_insert	6.43	6.32	-1.71
oltp_insert	3.07	3.07	0.0
oltp_read_write	11.45	11.45	0.0
oltp_update_index	3.19	3.25	1.88
oltp_update_non_index	3.13	3.13	0.0
oltp_write_only	6.09	6.09	0.0
types_delete_insert	6.79	6.79	0.0

[coffeegoddd]

@coffeegoddd DOLT

read_tests	from_latency	to_latency	percent_change
covering_index_scan	0.55	0.55	0.0
groupby_scan	10.09	9.73	-3.57
index_join	1.86	1.82	-2.15
index_join_scan	1.37	1.34	-2.19
index_scan	21.89	21.89	0.0
oltp_point_select	0.27	0.27	0.0
oltp_read_only	5.28	5.28	0.0
select_random_points	0.54	0.54	0.0
select_random_ranges	0.56	0.55	-1.79
table_scan	22.28	22.28	0.0
types_table_scan	66.84	66.84	0.0

write_tests	from_latency	to_latency	percent_change
oltp_delete_insert	6.32	6.32	0.0
oltp_insert	3.07	3.07	0.0
oltp_read_write	11.45	11.45	0.0
oltp_update_index	3.19	3.19	0.0
oltp_update_non_index	3.13	3.13	0.0
oltp_write_only	6.09	6.09	0.0
types_delete_insert	6.91	6.91	0.0

[coffeegoddd]

@zachmu DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
6a1704a	ok	5937471

version	total_tests
6a1704a	5937471

correctness_percentage
100.0

[coffeegoddd]

@zachmu DOLT

test_name	from_latency_p95	to_latency_p95	percent_change
tpcc-scale-factor-1	62.19	62.19	0.0

test_name	from_server_name	from_server_version	from_tps	to_server_name	to_server_version	to_tps	percent_change
tpcc-scale-factor-1	dolt	94fa063	37.46	dolt	6a1704a	36.89	-1.52

[coffeegoddd]

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
1424089	ok	5937471

version	total_tests
1424089	5937471

correctness_percentage
100.0

[coffeegoddd]

@coffeegoddd DOLT

test_name	from_latency_p95	to_latency_p95	percent_change
tpcc-scale-factor-1	61.08	62.19	1.82

test_name	from_server_name	from_server_version	from_tps	to_server_name	to_server_version	to_tps	percent_change
tpcc-scale-factor-1	dolt	94fa063	37.7	dolt	1424089	37.23	-1.25

[reltuk]

Woah, totally sweet. A few small comments, nothing major. Take 'em or leave 'em!

[coffeegoddd]

@zachmu DOLT

read_tests	from_latency	to_latency	percent_change
covering_index_scan	0.55	0.58	5.45
groupby_scan	10.09	9.91	-1.78
index_join	1.86	1.82	-2.15
index_join_scan	1.37	1.34	-2.19
index_scan	22.28	22.28	0.0
oltp_point_select	0.27	0.27	0.0
oltp_read_only	5.28	5.28	0.0
select_random_points	0.54	0.53	-1.85
select_random_ranges	0.55	0.55	0.0
table_scan	22.28	22.69	1.84
types_table_scan	66.84	66.84	0.0

write_tests	from_latency	to_latency	percent_change
oltp_delete_insert	6.32	6.32	0.0
oltp_insert	2.76	3.07	11.23
oltp_read_write	11.45	11.45	0.0
oltp_update_index	3.19	3.19	0.0
oltp_update_non_index	3.13	3.13	0.0
oltp_write_only	6.09	6.09	0.0
types_delete_insert	6.79	6.91	1.77

[coffeegoddd]

@coffeegoddd DOLT

read_tests	from_latency	to_latency	percent_change
covering_index_scan	0.54	0.58	7.41
groupby_scan	10.09	9.91	-1.78
index_join	1.86	1.82	-2.15
index_join_scan	1.34	1.32	-1.49
index_scan	22.28	22.28	0.0
oltp_point_select	0.27	0.28	3.7
oltp_read_only	5.37	5.37	0.0
select_random_points	0.54	0.54	0.0
select_random_ranges	0.55	0.56	1.82
table_scan	22.69	22.28	-1.81
types_table_scan	66.84	68.05	1.81

write_tests	from_latency	to_latency	percent_change
oltp_delete_insert	6.32	6.32	0.0
oltp_insert	3.07	3.07	0.0
oltp_read_write	11.45	11.45	0.0
oltp_update_index	3.25	3.19	-1.85
oltp_update_non_index	3.13	3.13	0.0
oltp_write_only	6.09	6.09	0.0
types_delete_insert	6.91	6.91	0.0

[coffeegoddd]

@zachmu DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
3bda2f9	ok	5937471

version	total_tests
3bda2f9	5937471

correctness_percentage
100.0

[coffeegoddd]

@zachmu DOLT

test_name	from_latency_p95	to_latency_p95	percent_change
tpcc-scale-factor-1	61.08	62.19	1.82

test_name	from_server_name	from_server_version	from_tps	to_server_name	to_server_version	to_tps	percent_change
tpcc-scale-factor-1	dolt	94fa063	37.94	dolt	3bda2f9	37.27	-1.77

[coffeegoddd]

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
f8e05a9	ok	5937471

version	total_tests
f8e05a9	5937471

correctness_percentage
100.0

[coffeegoddd]

@coffeegoddd DOLT

test_name	from_latency_p95	to_latency_p95	percent_change
tpcc-scale-factor-1	62.19	62.19	0.0

test_name	from_server_name	from_server_version	from_tps	to_server_name	to_server_version	to_tps	percent_change
tpcc-scale-factor-1	dolt	94fa063	37.46	dolt	f8e05a9	37.1	-0.96

[coffeegoddd]

@zachmu DOLT

read_tests	from_latency	to_latency	percent_change
covering_index_scan	0.55	0.58	5.45
groupby_scan	10.27	10.09	-1.75
index_join	1.82	1.82	0.0
index_join_scan	1.34	1.34	0.0
index_scan	22.28	22.28	0.0
oltp_point_select	0.27	0.28	3.7
oltp_read_only	5.37	5.37	0.0
select_random_points	0.54	0.54	0.0
select_random_ranges	0.56	0.56	0.0
table_scan	22.28	22.69	1.84
types_table_scan	66.84	68.05	1.81

write_tests	from_latency	to_latency	percent_change
oltp_delete_insert	6.43	6.43	0.0
oltp_insert	3.07	3.07	0.0
oltp_read_write	11.65	11.45	-1.72
oltp_update_index	3.25	3.25	0.0
oltp_update_non_index	3.19	3.13	-1.88
oltp_write_only	6.21	6.09	-1.93
types_delete_insert	6.91	6.91	0.0

[coffeegoddd]

@zachmu DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
2d0493d	ok	5937471

version	total_tests
2d0493d	5937471

correctness_percentage
100.0

[coffeegoddd]

@zachmu DOLT

test_name	from_latency_p95	to_latency_p95	percent_change
tpcc-scale-factor-1	62.19	62.19	0.0

test_name	from_server_name	from_server_version	from_tps	to_server_name	to_server_version	to_tps	percent_change
tpcc-scale-factor-1	dolt	94fa063	37.4	dolt	2d0493d	37.5	0.27