Update DoltTable.ProjectedTags() to distinguish between no set projectedCols and zero projectedCols#10455
Merged
angelamayxie merged 14 commits intomainfrom Feb 10, 2026
Merged
Update DoltTable.ProjectedTags() to distinguish between no set projectedCols and zero projectedCols#10455angelamayxie merged 14 commits intomainfrom
DoltTable.ProjectedTags() to distinguish between no set projectedCols and zero projectedCols#10455angelamayxie merged 14 commits intomainfrom
Conversation
…n completely pruned and no projected columns set
Contributor
|
@angelamayxie DOLT
|
Contributor
|
@angelamayxie DOLT
|
Contributor
|
@coffeegoddd DOLT
|
DoltTable.ProjectedTags() to distinguish between no set projectedCols and zero projectedCols
Contributor
|
@angelamayxie DOLT
|
Contributor
|
@angelamayxie DOLT
|
Contributor
|
#benchmark-mini |
1 similar comment
[auto-bump] [no-release-notes] dependency by angelamayxie
Contributor
|
@jycor DOLT
|
Contributor
Contributor
|
@angelamayxie DOLT
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #10451
When getting
ProjectedTags(), we were not distinguishing between whenprojectedColswasnil(meaning no projections are set so we should return all columns) and whenprojectedColswas an empty array of length 0 (meaning the table has been pruned to be zero columns but we still care about the number of rows), since in both cases,projectedColswould have a length of 0. This was causingLEFT OUTER JOINs that didn't project any left-side columns to not return the correct number of columns. This was fixed by checking for ifprojectedColswasnilinstead (which is what we do in other functions likeProjections()andHistoryTable.ProjectedTags()Also some minor refactorings:
getItatogetIndexedTableAccessgetSourceKvTest added in dolthub/go-mysql-server#3424