Various bug fixes for checking foreign key constraints during merge#10418
Merged
Various bug fixes for checking foreign key constraints during merge#10418
Conversation
…rmining whether to drop the index during merge.
… when creating a the CV marker
…index tuple, they must be mapped
Contributor
Hydrocharged
approved these changes
Feb 5, 2026
Contributor
Hydrocharged
left a comment
Hydrocharged
left a comment
There was a problem hiding this comment.
LGTM! No real comments to make
Contributor
This was referenced Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR mainly addresses the need to perform type conversions when performing index lookups when determining whether a diff introduces a foreign key constraint violation. The old code assumed that the key values were binary identical between parent and child table, and this isn't always the case (esp in Doltgres).
Also fixes a related bug in constructing the primary key from a secondary key, which occurs when a secondary index contains primary key columns.