add HashObject + GitAPIImpl write-primitive tests#10416
Merged
coffeegoddd merged 3 commits intomainfrom Feb 4, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new HashObject method to the internal Git plumbing API that enables streaming blob writes, and includes comprehensive unit tests for the write-path building blocks. The implementation wraps the git hash-object -w --stdin command to create blob objects directly in the Git object database.
Changes:
- Added
HashObjectmethod to theGitAPIinterface for writing blob objects from streaming content - Implemented
HashObjectinGitAPIImplusing the git CLI plumbing command - Added 7 comprehensive test cases covering blob writing, tree manipulation, ref updates, and commit operations
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| go/store/blobstore/internal/git/api.go | Added HashObject interface method definition with documentation |
| go/store/blobstore/internal/git/impl.go | Implemented HashObject method with output parsing and error handling |
| go/store/blobstore/internal/git/impl_test.go | Added comprehensive test coverage for HashObject and other write primitives including round-trip tests, empty blob handling, tree operations, ref management, and CAS updates |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
Author
|
@coffeegoddd DOLT
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the unified internal/git plumbing API with a streaming blob-write primitive and adds targeted unit coverage for the write building blocks we’ll use to implement GitBlobstore write paths.