Skip to content

Remove requirement for -i in dolt_rebase#10349

Merged
macneale4 merged 3 commits intomainfrom
macneale4-claude/rebase-non-ii
Jan 22, 2026
Merged

Remove requirement for -i in dolt_rebase#10349
macneale4 merged 3 commits intomainfrom
macneale4-claude/rebase-non-ii

Conversation

@macneale4
Copy link
Copy Markdown
Contributor

@macneale4 macneale4 commented Jan 21, 2026 •
edited
Loading

Hold over from the original impl of rebase now addressed!

@coffeegoddd
Copy link
Copy Markdown
Contributor

coffeegoddd commented Jan 22, 2026

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
1c3ad06 ok 5937471
version total_tests
1c3ad06 5937471
correctness_percentage
100.0

@macneale4 macneale4 marked this pull request as ready for review January 22, 2026 00:34
@macneale4 macneale4 requested a review from fulghum January 22, 2026 00:34
fulghum
fulghum approved these changes Jan 22, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@coffeegoddd
Copy link
Copy Markdown
Contributor

coffeegoddd commented Jan 22, 2026

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
5f2a48f ok 5937471
version total_tests
5f2a48f 5937471
correctness_percentage
100.0

@coffeegoddd
Copy link
Copy Markdown
Contributor

coffeegoddd commented Jan 22, 2026

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
1ef50d8 ok 5937471
version total_tests
1ef50d8 5937471
correctness_percentage
100.0

@macneale4 macneale4 merged commit e8387cd into main Jan 22, 2026
28 of 29 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Jan 23, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fulghum fulghum fulghum approved these changes

Assignees

No one assigned

Labels

correctness_approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@macneale4 @coffeegoddd @fulghum