Skip to content

Consistently implement which commands require a repo#10289

Merged
timsehn merged 8 commits intomainfrom
tim/fix-rerquires-repo
Jan 8, 2026
Merged

Consistently implement which commands require a repo#10289
timsehn merged 8 commits intomainfrom
tim/fix-rerquires-repo

Conversation

@timsehn
Copy link
Copy Markdown
Contributor

@timsehn timsehn commented Jan 7, 2026

Add a test file to ensure behavior

@coffeegoddd
Copy link
Copy Markdown
Contributor

@timsehn DOLT

comparing_percentages
100.000000 to 100.000000
version result total
ed15f70 ok 5937471
version total_tests
ed15f70 5937471
correctness_percentage
100.0

@coffeegoddd
Copy link
Copy Markdown
Contributor

@timsehn DOLT

comparing_percentages
100.000000 to 100.000000
version result total
aeaee6b ok 5937471
version total_tests
aeaee6b 5937471
correctness_percentage
100.0

timsehn and others added 2 commits January 7, 2026 17:41
- init.bats: Use status != 0 instead of status == 1 for flexibility
- shallow-clone.bats: Add cd into cloned directory after dolt_clone
- sql-local-remote.bats: Run commands from within the dolt database directory

These tests now properly cd into the dolt database directory before
running commands that require a repository context.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
archive-inspect and journal-inspect commands inspect external files
and should not require being run from within a dolt repository.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@timsehn timsehn requested a review from macneale4 January 8, 2026 02:06
@coffeegoddd
Copy link
Copy Markdown
Contributor

@timsehn DOLT

comparing_percentages
100.000000 to 100.000000
version result total
5f1f4fc ok 5937471
version total_tests
5f1f4fc 5937471
correctness_percentage
100.0

@coffeegoddd
Copy link
Copy Markdown
Contributor

@timsehn DOLT

comparing_percentages
100.000000 to 100.000000
version result total
5313db0 ok 5937471
version total_tests
5313db0 5937471
correctness_percentage
100.0

Copy link
Copy Markdown
Contributor

@macneale4 macneale4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. pushed feedback as changes.

@timsehn
Copy link
Copy Markdown
Contributor Author

timsehn commented Jan 8, 2026

Will merge if tests pass

@coffeegoddd
Copy link
Copy Markdown
Contributor

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
75f15a4 ok 5937471
version total_tests
75f15a4 5937471
correctness_percentage
100.0

@timsehn timsehn merged commit 2107971 into main Jan 8, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The current directory is not a valid dolt repository. inconsistently reported inside a dolt repository

3 participants